From owner-cvs-all@FreeBSD.ORG  Wed Oct 26 19:45:18 2011
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35])
	by hub.freebsd.org (Postfix) with ESMTP id C699B106564A;
	Wed, 26 Oct 2011 19:45:18 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org
	[IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id 44B2014EA4D;
	Wed, 26 Oct 2011 19:44:52 +0000 (UTC)
Message-ID: <4EA86333.8090804@FreeBSD.org>
Date: Wed, 26 Oct 2011 12:44:51 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:7.0.1) Gecko/20111001 Thunderbird/7.0.1
MIME-Version: 1.0
To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>
References: <201110261620.p9QGK0vV010389@repoman.freebsd.org>
In-Reply-To: <201110261620.p9QGK0vV010389@repoman.freebsd.org>
X-Enigmail-Version: undefined
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Olivier Cochard-Labbe <olivier@cochard.me>, cvs-ports@FreeBSD.org,
	cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/www/shellinabox Makefile
 ports/www/shellinabox/files shellinaboxd.in
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Oct 2011 19:45:18 -0000

On 10/26/2011 09:20, Sunpoet Po-Chuan Hsieh wrote:
> sunpoet     2011-10-26 16:20:00 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     www/shellinabox      Makefile 
>     www/shellinabox/files shellinaboxd.in 
>   Log:
>   - Unset shellinaboxd_user and shellinaboxd_group at the end of rc script to
>     avoid unnecessary su(1) initiated by rc.subr

I solved this in the named rc.d script by using _uid, which is not
special to rc.subr; instead of _user, which is. Also, the following
should probably be changed:

if [ "${shellinaboxd_certfile}" = "" ]; then

to

if [ -n "${shellinaboxd_certfile}" ]; then

Otherwise this script looks real good, thanks. :)

>   - Pet portlint
>   - Bump PORTREVISION for package change
>   
>   Reported by:    ed (in the followup of ports/151314)
>   Approved by:    Olivier Cochard-Labbe <olivier@cochard.me> (maintainer)
>   
>   Revision  Changes    Path
>   1.6       +4 -4      ports/www/shellinabox/Makefile
>   1.6       +4 -1      ports/www/shellinabox/files/shellinaboxd.in
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/shellinabox/Makefile.diff?&r1=1.5&r2=1.6&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/shellinabox/files/shellinaboxd.in.diff?&r1=1.5&r2=1.6&f=h
> 



-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/