From owner-freebsd-ppc@FreeBSD.ORG Thu Dec 20 21:19:27 2007 Return-Path: Delivered-To: powerpc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DE8E316A417 for ; Thu, 20 Dec 2007 21:19:27 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from smtpoutm.mac.com (smtpoutm.mac.com [17.148.16.76]) by mx1.freebsd.org (Postfix) with ESMTP id C885313C4F4 for ; Thu, 20 Dec 2007 21:19:27 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from mac.com (asmtp001-s [10.150.69.64]) by smtpoutm.mac.com (Xserve/smtpout013/MantshX 4.0) with ESMTP id lBKL5i0a019810; Thu, 20 Dec 2007 13:05:44 -0800 (PST) Received: from mini-g4.jnpr.net (natint3.juniper.net [66.129.224.36]) (authenticated bits=0) by mac.com (Xserve/asmtp001/MantshX 4.0) with ESMTP id lBKL5gYq022530 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Thu, 20 Dec 2007 13:05:42 -0800 (PST) Message-Id: <1B950FDE-456B-4821-AC21-D8288407E921@mac.com> From: Marcel Moolenaar To: John Baldwin In-Reply-To: <200712201431.56657.jhb@freebsd.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v915) Date: Thu, 20 Dec 2007 13:05:36 -0800 References: <200712201431.56657.jhb@freebsd.org> X-Mailer: Apple Mail (2.915) Cc: powerpc@freebsd.org Subject: Re: Only set bus tag/handles in activate_resource() methods X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2007 21:19:28 -0000 On Dec 20, 2007, at 11:31 AM, John Baldwin wrote: > This patch (untested) tries to fix an issue on powerpc I fixed on the > ACPI-using platforms a while back. It fixes the top-level bus > drivers to > activate resources (assign bus tags and handles so you can use > bus_space_*()) > in bus_activate_resource() methods instead of in > bus_alloc_resource(). This > is important for any drivers that want do what ACPI does: allocate a > resource > and then subdivide it to hand it out to child devices. A driver > that does > this can still pass the bus_activate_resource() request up the tree to > actually bet bus_space setup with this fix. I like it. Feel free to commit. I'll test it afterwards. FYI, -- Marcel Moolenaar xcllnt@mac.com