Date: Sat, 23 Jul 2011 17:36:32 -0700 From: Brian Somers <brian@FreeBSD.org> To: Doug Barton <dougb@FreeBSD.org> Cc: "b. f." <bf1783@googlemail.com>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, riggs@rrr.de, bf1783@gmail.com, cvs-ports@FreeBSD.org, Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org> Subject: Re: cvs commit: ports/multimedia/mencoder Makefile Message-ID: <20110724003632.GA3604@thong.lan.Awfulhak.org> In-Reply-To: <4E2B2B82.1020506@FreeBSD.org> References: <201107200252.p6K2qZRb053515@repoman.freebsd.org> <CAGFTUwMZ5iAp=VvNZezX4fiGy2d5Ep6jaSWWUZp92KTobxkjsQ@mail.gmail.com> <4E2B2B82.1020506@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jul 23, 2011 at 01:13:54PM -0700, Doug Barton wrote:
> On 07/22/2011 23:07, b. f. wrote:
>
> > I must renew my plea to avoid these "fixes". When a user sets
> > WITH/WITHOUT_FOO, he means precisely "build this port
> > WITH/WITHOUT_FOO", and not "build this port WITH/WITHOUT_FOO, except
> > if package X is installed, and, if it is, silently do something else",
> > and we should not be adding code to do the latter. We should instead
> > patch the broken distribution configure scripts and Makefiles, so that
> > the problem does not occur. If a lack of time or another problem
> > prevents this from being done initially, then as a temporary
> > workaround, we should add something like:
> >
> > .if exists(${LOCALBASE}/lib/libass.so) && defined(WITHOUT_ASS)
> > BROKEN= libass is installed, so broken mplayer scripts will ignore WITHOUT_ASS
> > .endif
> >
> > so that the user will know that his choice of options cannot be used,
> > and he can take the appropriate action -- and he will not be misled
> > into thinking that his choice of options are used when they are not.
>
> +1
>
> --
>
> Nothin' ever doesn't change, but nothin' changes much.
> -- OK Go
>
> Breadth of IT experience, and depth of knowledge in the DNS.
> Yours for the right price. :) http://SupersetSolutions.com/
>
Agreed. Any code that changes behaviour based on what's installed
is broken as it alters its output across multiple runs. Specifically,
a super-port that just depends on a whole bunch of other ports can
get into a lot of trouble when you "make && sudo make package" as
the packaging stage of each component port may have requirements
that weren't met during the first make.
--
Brian Somers <brian@Awfulhak.org>
Don't _EVER_ lose your sense of humour ! <brian@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110724003632.GA3604>