From owner-svn-src-all@freebsd.org Tue Oct 22 15:29:15 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A9B5415D929; Tue, 22 Oct 2019 15:29:15 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 46yHVM3HZXz3QJ0; Tue, 22 Oct 2019 15:29:15 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id x9MFTDes086245 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 22 Oct 2019 08:29:13 -0700 (PDT) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id x9MFTDqM086244; Tue, 22 Oct 2019 08:29:13 -0700 (PDT) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Tue, 22 Oct 2019 08:29:13 -0700 From: Gleb Smirnoff To: Li-Wen Hsu , br@freebsd.org Cc: src-committers , svn-src-all , svn-src-head Subject: Re: svn commit: r353876 - head/sys/kern Message-ID: <20191022152913.GJ4086@FreeBSD.org> References: <201910212312.x9LNCEbX052414@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 46yHVM3HZXz3QJ0 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.95 / 15.00]; NEURAL_HAM_MEDIUM(-0.95)[-0.954,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Oct 2019 15:29:15 -0000 Li-Wen, On Tue, Oct 22, 2019 at 04:28:45PM +0800, Li-Wen Hsu wrote: L> > Modified: head/sys/kern/subr_epoch.c L> > ============================================================================== L> > --- head/sys/kern/subr_epoch.c Mon Oct 21 21:21:34 2019 (r353875) L> > +++ head/sys/kern/subr_epoch.c Mon Oct 21 23:12:14 2019 (r353876) L> > @@ -366,9 +366,13 @@ _epoch_enter_preempt(epoch_t epoch, epoch_tracker_t et L> > struct thread *td; L> > L> > MPASS(cold || epoch != NULL); L> > - INIT_CHECK(epoch); L> > MPASS(epoch->e_flags & EPOCH_PREEMPT); L> > td = curthread; L> > + MPASS((vm_offset_t)et >= td->td_kstack && L> > + (vm_offset_t)et + sizeof(struct epoch_tracker) < L> > + td->td_kstack + td->td_kstack_pages * PAGE_SIZE); L> > + L> > + INIT_CHECK(epoch); L> > #ifdef EPOCH_TRACE L> > epoch_trace_enter(td, epoch, et, file, line); L> > #endif L> L> Hello Gleb, L> L> RISC-V boot panics with this message: L> L> panic: Assertion (vm_offset_t)et >= td->td_kstack && (vm_offset_t)et + L> sizeof(struct epoch_tracker) < td->td_kstack + td->td_kstack_pages * L> PAGE_SIZE failed at /workspace/src/sys/kern/subr_epoch.c:373 L> L> Full log: https://ci.freebsd.org/job/FreeBSD-head-riscv64-test/12334/console L> L> Can you help check this? I need help from RISC-V experts. Can you please meanwhile print out values of et and td->td_kstack? -- Gleb Smirnoff