Date: Mon, 20 Dec 2021 00:50:50 -0600 From: Kyle Evans <kevans@freebsd.org> To: Wojciech Macek <wma@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 4f741801d860 - main - t_setrlimit: Adjust resource limit to 20M Message-ID: <CACNAnaHMg5WpXQT_TEVPq3STmtgjwL1Mhzc3c02zvS1UR-Epmg@mail.gmail.com> In-Reply-To: <202112200529.1BK5T0np047358@gitrepo.freebsd.org> References: <202112200529.1BK5T0np047358@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Dec 19, 2021 at 11:29 PM Wojciech Macek <wma@freebsd.org> wrote: > > The branch main has been updated by wma: > > URL: https://cgit.FreeBSD.org/src/commit/?id=4f741801d86089a1c5d631ba1e0f1421cdcf7a7e > > commit 4f741801d86089a1c5d631ba1e0f1421cdcf7a7e > Author: Dawid Gorecki <dgr@semihalf.com> > AuthorDate: 2021-12-20 05:27:12 +0000 > Commit: Wojciech Macek <wma@FreeBSD.org> > CommitDate: 2021-12-20 05:28:20 +0000 > > t_setrlimit: Adjust resource limit to 20M > > With ASLR enabled by default, RLIMIT_STACK test fails due to the fact > that default stack gap can be as big as 15M. Because of that the > resource limit of 4M results in test program receiving SIGSEGV > immediately after exiting the setrlimit syscall. Since the idea of this > test is to check if rlim_cur does not extend past rlim_max, adjusting > the resource limit to 20M should not invalidate the test results. > I can't seem to find the PR at the moment, but isn't this exactly the kind of thing markj@ talked about trying to avoid elsewhere? It seems like this probably should've been involved in the discussion rather than hacked around independently. Thanks, Kyle Evans
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaHMg5WpXQT_TEVPq3STmtgjwL1Mhzc3c02zvS1UR-Epmg>