From owner-svn-src-head@freebsd.org Tue Mar 7 04:04:22 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2F22AD01212; Tue, 7 Mar 2017 04:04:22 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x244.google.com (mail-pg0-x244.google.com [IPv6:2607:f8b0:400e:c05::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EFCC21B1E; Tue, 7 Mar 2017 04:04:21 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x244.google.com with SMTP id 77so8877957pgc.0; Mon, 06 Mar 2017 20:04:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=3KBwyTsPOfurwVDQYCuzu8BQaUIxHscVbSrJcXA3FkU=; b=gfIS68GeSJAIjPQpvKbbJglvlN7v1cEZ+8vHlx1TGBC5OV1yOBstIN1I94QKG7OtAd dPQ/8fQSUAbFQpKCovrxHbR6FMyBWbW3+I0Qrqih3GZHRAFItjOVZKTugSoHjIuGyd0C RHmiXg40EPodxPDg1Q+NDPfNWGpgMAeuzFGDaIBPfB05YBi/LBdWFaF83Nf7AghikQBm vU2QE5708NlzemCwEi26DqC1YU3riwjbf1FBaZNUzM0LmShC0NGQrb6BKpT8RYOokCVC yMXD0SygX3WHU6IJ1GEWXFQulcDwDrzVuk2B+tWJyZzkZPqydVxeGYcbhY/Q0IRny1Fq H1Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=3KBwyTsPOfurwVDQYCuzu8BQaUIxHscVbSrJcXA3FkU=; b=nLE5vrXUBCL6cEXsUnrEcdkZOFUQjSti7zpQ6fs5P6Wvx/RLOQPkQ3hz89SHtocpL5 Oh6Vs4siS99X1y/v938ddLtNjIrpE69Z141BagTAZPWnw/jIC7aANoLAkkbcks23HSIK Ef72+13PQc4WhLEAd4BcZIsgi72x6JNyQcrp0YL2bEjWJMtgZ7d91eFaSfsOoFOxKqH+ mqV2DvU3Z/z+NtzU6lgpQmUleQWcJvg3mkIuTWHAPxWuWqP74gpTej2gdivS6IguMEfS ShyOJzLl2+epuwR7FHhiggxMsPQuiYlQF7I5t7FDyFVDcrJZXmy4Xp4bB9R6rXL90aui OdPA== X-Gm-Message-State: AMke39lp7rDyNUwR0T7sntIcoA+E3gL8f8xfot6am/Lqto+zp23uleiFL5/Awr0uPCM3CQ== X-Received: by 10.84.129.3 with SMTP id 3mr32001461plb.150.1488859460942; Mon, 06 Mar 2017 20:04:20 -0800 (PST) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id m136sm42509910pga.22.2017.03.06.20.04.19 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 06 Mar 2017 20:04:20 -0800 (PST) Subject: Re: svn commit: r314813 - head/sys/kern Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_BE731604-DDB7-4FF4-A7DE-13CC71B59B16"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <9747B513-8D23-487D-8FF9-721265C1CF44@gmail.com> Date: Mon, 6 Mar 2017 20:04:19 -0800 Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org, Gleb Smirnoff Message-Id: <2CEAC560-E2D2-4790-9006-FEED1BFF5A78@gmail.com> References: <201703070020.v270K2vA039655@repo.freebsd.org> <9747B513-8D23-487D-8FF9-721265C1CF44@gmail.com> To: Hiren Panchasara X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 04:04:22 -0000 --Apple-Mail=_BE731604-DDB7-4FF4-A7DE-13CC71B59B16 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 6, 2017, at 19:08, Ngie Cooper (yaneurabeya) = wrote: =E2=80=A6 > The KASSERT is bad =E2=80=94 please fix it. =46rom = https://ci.freebsd.org/job/FreeBSD-head-amd64-test/1994/console : >=20 > add host 127.0.0.1panic: sbcut_internal: len is 0 but it is supposed = to be +ve len =3D=3D 0 has special meaning; please see sbflush_internal. This = works. Thanks, -Ngie $ svn diff sys/kern/uipc_sockbuf.c Index: sys/kern/uipc_sockbuf.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/kern/uipc_sockbuf.c (revision 314827) +++ sys/kern/uipc_sockbuf.c (working copy) @@ -1043,8 +1043,7 @@ { struct mbuf *m, *next, *mfree; - KASSERT(len > 0, ("%s: len is %d but it is supposed to be +ve", - __func__, len)); + KASSERT(len >=3D 0, ("%s: len is negative (%d)", __func__, = len)); KASSERT(len <=3D sb->sb_ccc, ("%s: len: %d is > ccc: %u", __func__, len, sb->sb_ccc)); --Apple-Mail=_BE731604-DDB7-4FF4-A7DE-13CC71B59B16 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYvjFDAAoJEPWDqSZpMIYV2C4P/R/mEhZeNSeOXOfoYeb71RmI YbnBfeS+aoojK5KswcgEmsGHcTBBDAuncNhAysz19h/BX98X14dBRq9qw7YjGZml b0SlaBSciVCPgIoDXmOPks3btbnxDOUdzSRYPe2RPW4uQtD+YYDjpSmpvOk0Ukyx MdhHHc9QNxJ+Pl47QF6nI/835/w/SU5Muhv2UQ8zTabQCymk6NPnU78MoDWc1mJH tJqEQldpPCMt6tbyhqDuZTq0WapMueBjGox+ZarS5+WSq9YZEwmIASFsK6av33pG kC96mzEQdljt76ffMpqx6Hx/1+e9HDU7w9hJ4irlcZRH0+t2AunKfkpX9TfbCJ2l cxLCvg9TIhYSg73S0slpMFK+6zrqDCPxihkmShaU8HrinPlDhWIApyyhEiS5b0wn F2zEK6AjoRagyIl15GJSZy+SpV6Bcr1civDfQ853kB2PMnP+nhgpFc2ODb5vgMpM K+wtQVb1/sxQj3w9sriukpfVlriEdYKH5goQGXK/DsTqXsbmILAMIyYjWOoLEJn/ YsS35SYVo53QwdyYvgss3Qh3BflNJidmYW1xQHBIeuM5u+r6S+HdK+hDtq6ccpHV z0TzPLUbhgqbBMeKyBitJjbpU/cu0NDonARQyHsnjZiBQKe9+8/psUNN678+gl0k fP7L35mZ10ftWiZIlTQN =JFcS -----END PGP SIGNATURE----- --Apple-Mail=_BE731604-DDB7-4FF4-A7DE-13CC71B59B16--