From owner-cvs-all@FreeBSD.ORG  Thu Sep 16 16:58:30 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C6CF316A4D2
	for <cvs-all@FreeBSD.org>; Thu, 16 Sep 2004 16:58:30 +0000 (GMT)
Received: from mail1.speakeasy.net (mail1.speakeasy.net [216.254.0.201])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8AEF443D3F
	for <cvs-all@FreeBSD.org>; Thu, 16 Sep 2004 16:58:30 +0000 (GMT)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 7123 invoked from network); 16 Sep 2004 16:58:29 -0000
Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx)
	([216.27.160.63])          (envelope-sender <jhb@FreeBSD.org>)
	encrypted SMTP
	for <cvs-all@FreeBSD.org>; 16 Sep 2004 16:58:29 -0000
Received: from [10.50.40.210] (gw1.twc.weather.com [216.133.140.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i8GGwOua066233;
	Thu, 16 Sep 2004 12:58:25 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
From: John Baldwin <jhb@FreeBSD.org>
To: des@des.no (Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?=)
Date: Thu, 16 Sep 2004 10:36:02 -0400
User-Agent: KMail/1.6.2
References: <200409160537.i8G5bemV019545@repoman.freebsd.org>
	<xzpmzzqpewe.fsf@dwp.des.no>
In-Reply-To: <xzpmzzqpewe.fsf@dwp.des.no>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <200409161036.02801.jhb@FreeBSD.org>
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: Julian Elischer <julian@FreeBSD.org>
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_switch.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Sep 2004 16:58:30 -0000

On Thursday 16 September 2004 08:38 am, Dag-Erling Sm=F8rgrav wrote:
> Julian Elischer <julian@FreeBSD.org> writes:
> >   Log:
> >   e specific code to revert a partial add ot teh run queue, not
> >   remrunqueue() which can't handle a partially added thread.
>
> begyerpar'n?

The earlier fix to maybe_preempt() would call 'remrunqueue()' to have a thr=
ead=20
that is being preempted to removed from its ksegroup runqueue, however,=20
remrunqueue() is for removing the thread from all runqueues, and it is=20
probably not really safe to call that as the thread is not in a full runque=
ue=20
state so to speak. Thus, Julian inlined specific code to just remove the=20
thread from the ksegroup runqueue.  I do wonder if that code shouldn't at=20
least be consolidated into a function that is called by remrunqueue(),=20
adjustrunqueue(), and maybe_preempt().  Also, the commit message could use =
a=20
bit more detail. :)

=2D-=20
John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =3D  http://www.FreeBSD.org