From owner-freebsd-bugs@FreeBSD.ORG Fri Feb 10 18:50:04 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BD97F16A423 for ; Fri, 10 Feb 2006 18:50:04 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id E02B943D49 for ; Fri, 10 Feb 2006 18:50:03 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k1AIo389010151 for ; Fri, 10 Feb 2006 18:50:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k1AIo3d9010150; Fri, 10 Feb 2006 18:50:03 GMT (envelope-from gnats) Resent-Date: Fri, 10 Feb 2006 18:50:03 GMT Resent-Message-Id: <200602101850.k1AIo3d9010150@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ulf Lilleengen Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 683CD16A420 for ; Fri, 10 Feb 2006 18:46:12 +0000 (GMT) (envelope-from lulf@studby.ntnu.no) Received: from royk.itea.ntnu.no (royk.itea.ntnu.no [129.241.190.230]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7B7FF43D53 for ; Fri, 10 Feb 2006 18:46:07 +0000 (GMT) (envelope-from lulf@studby.ntnu.no) Received: from localhost (localhost [127.0.0.1]) by royk.itea.ntnu.no (Postfix) with ESMTP id A974F66D41 for ; Fri, 10 Feb 2006 19:46:05 +0100 (CET) Received: from studby.ntnu.no (m062g.studby.ntnu.no [129.241.134.62]) by royk.itea.ntnu.no (Postfix) with ESMTP for ; Fri, 10 Feb 2006 19:46:05 +0100 (CET) Received: by studby.ntnu.no (Postfix, from userid 1001) id E261722887; Fri, 10 Feb 2006 19:46:08 +0100 (CET) Message-Id: <20060210184608.E261722887@studby.ntnu.no> Date: Fri, 10 Feb 2006 19:46:08 +0100 (CET) From: Ulf Lilleengen To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/93145: [PATCH] 6.1-BETA1 DHCP config error X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Ulf Lilleengen List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Feb 2006 18:50:04 -0000 >Number: 93145 >Category: bin >Synopsis: [PATCH] 6.1-BETA1 DHCP config error >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Feb 10 18:50:02 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Ulf Lilleengen >Release: FreeBSD 7.0-CURRENT i386 >Organization: >Environment: System: FreeBSD vimes.studby.ntnu.no 7.0-CURRENT FreeBSD 7.0-CURRENT #4: Wed Jan 25 21:16:02 CET 2006 root@vimes.studby.ntnu.no:/usr/obj/usr/src/sys/VIMES i386 >Description: When i try to install 6.1-BETA1 and choose to use DHCP to configure my rl0 interface, i get an error saying "ifconfig: DHCP: bad value" coming from the installer trying to run ifconfig rl0 DHCP. I looked at the code in network.c in sysinstall, and found a difference between CURRENT and BETA1, which was an strstr check being changed. Patch added below. >How-To-Repeat: Try install 6.1-BETA1 and configure network interface with DHCP >Fix: --- sysinstall_dhcpconfig.diff begins here --- Index: network.c =================================================================== RCS file: /home/cvs/ncvs/src/usr.sbin/sysinstall/network.c,v retrieving revision 1.51 diff -u -r1.51 network.c --- network.c 1 Nov 2002 02:05:05 -0000 1.51 +++ network.c 10 Feb 2006 18:37:24 -0000 @@ -126,7 +126,7 @@ snprintf(ifconfig, 255, "%s%s", VAR_IFCONFIG, dev->name); cp = variable_get(ifconfig); if (cp) { - if (strcmp(cp, "DHCP")) { + if (strcmp(cp, "DHCP") == NULL) { msgDebug("ifconfig %s %s\n", dev->name, cp); i = vsystem("ifconfig %s %s", dev->name, cp); if (i) { --- sysinstall_dhcpconfig.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: