From owner-svn-src-head@FreeBSD.ORG Wed Jun 5 08:50:04 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 506669A1; Wed, 5 Jun 2013 08:50:04 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-ie0-x233.google.com (mail-ie0-x233.google.com [IPv6:2607:f8b0:4001:c03::233]) by mx1.freebsd.org (Postfix) with ESMTP id 098741C47; Wed, 5 Jun 2013 08:50:03 +0000 (UTC) Received: by mail-ie0-f179.google.com with SMTP id c13so2917988ieb.24 for ; Wed, 05 Jun 2013 01:50:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=iQylUf7GA1r6dcQT0dt39YMgSbHKvUv/abW2oP0DhYM=; b=UkZwRijDTvTYhDE6Aip7yiKrOF3utIP8EyDh47PwajqkavO9/bABAqSrRfeZwDx7Kj SNRfBa8rEHxboiIefXrovFJybdUaf3i8ydYxUqGf9NWIYmNNVybiVIz9or+QqdUEZc1f gdpzAEzHsOKtk5oUFIxWxTblwwsTeM4jwCdEBdqQZ+hrEtBu1lEXzaAQiMNDapUas5Yk gTvCluYXlGoa8qHgUDLY2qDXNlBEn/eJdd5zO+xrYaFupBcf40rWnUhe+zJ69j1jYz/u 9y7wckg2fMaZ8a3bn6PuXJAbMA7o0+WERKwN5DyIkGuvkxl1qMfq4ecEOZyhEHZFbGGL JUMA== MIME-Version: 1.0 X-Received: by 10.50.118.69 with SMTP id kk5mr2684785igb.36.1370422203271; Wed, 05 Jun 2013 01:50:03 -0700 (PDT) Received: by 10.64.71.101 with HTTP; Wed, 5 Jun 2013 01:50:03 -0700 (PDT) Received: by 10.64.71.101 with HTTP; Wed, 5 Jun 2013 01:50:03 -0700 (PDT) In-Reply-To: <20130605081301.GA42959@zim.MIT.EDU> References: <201306050533.r555X2dQ047208@svn.freebsd.org> <20130605081301.GA42959@zim.MIT.EDU> Date: Wed, 5 Jun 2013 09:50:03 +0100 Message-ID: Subject: Re: svn commit: r251404 - in head/lib/msun: . src From: Chris Rees To: David Schultz Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jun 2013 08:50:04 -0000 On 5 Jun 2013 09:13, "David Schultz" wrote: > > On Wed, Jun 05, 2013, Chris Rees wrote: > > On 5 Jun 2013 06:33, "David Schultz" wrote: > > > > > > Author: das > > > Date: Wed Jun 5 05:33:01 2013 > > > New Revision: 251404 > > > URL: http://svnweb.freebsd.org/changeset/base/251404 > > > > > > Log: > > > Style fixes. > > > > > > Submitted by: bde > > > > > > Modified: > > > head/lib/msun/Makefile > > > head/lib/msun/src/catrig.c > > > head/lib/msun/src/catrigf.c > > > head/lib/msun/src/e_log2.c > > > > > > Modified: head/lib/msun/Makefile > > > > > ============================================================================== > > > --- head/lib/msun/Makefile Wed Jun 5 01:22:59 2013 (r251403) > > > +++ head/lib/msun/Makefile Wed Jun 5 05:33:01 2013 (r251404) > > > @@ -21,6 +21,10 @@ ARCH_SUBDIR= ${MACHINE_CPUARCH} > > > .include "${ARCH_SUBDIR}/Makefile.inc" > > > > > > .PATH: ${.CURDIR}/${ARCH_SUBDIR} > > > +.if ${MACHINE_CPUARCH} == "i386" || ${MACHINE_CPUARCH} == "amd64" > > > +.PATH: ${.CURDIR}/x86 > > > +CFLAGS+= -I${.CURDIR}/x86 > > > +.endif > > > > Since you're doing style fixes, it is worth noting that quoting strings in > > Makefiles is nearly always incorrect, and only works in our make because of > > an extension. > > Thanks -- I didn't know that, and apparently neither did whoever > wrote that line originally. But quoted strings are pervasive in > our makefiles; if there's a good reason to fix it, perhaps you > could go through and clean them up. :) I've thought about this, but really that kind of fix is repo churn. I'll see if I can find somewhere appropriate to document it; the only real harm is that people using other makes are constantly surprised when things like ifeq($(ARCH),"amd64") never match. Obviously this isn't directly our problem, but it's a nice portability concern. Chris