From owner-freebsd-ports-bugs@freebsd.org Wed Oct 12 17:48:47 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2A2FDC0F591 for ; Wed, 12 Oct 2016 17:48:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1632E28B for ; Wed, 12 Oct 2016 17:48:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u9CHmk9G082200 for ; Wed, 12 Oct 2016 17:48:46 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 213331] USES=gmake can break CMAKE_NINJA=yes Date: Wed, 12 Oct 2016 17:48:47 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rakuco@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2016 17:48:47 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D213331 --- Comment #2 from Raphael Kubo da Costa --- (In reply to Antoine Brodin from comment #1) > Can't you use something like this? > > .if !defined(CMAKE_NINJA) > USES+=3D gmake > .endif The problem with this is that it adds a burden to every single port that us= es CMake and cannot be built with bmake, which is not very feasible. One thing tcberner@ thought of a while ago was this in Uses/cmake.mk: .if ${USES:Mgmake} .include ${USESDIR}/gmake.mk .endif .if defined(CMAKE_NINJA) .include "${USESDIR}/ninja.mk" .endif which would give preference to ninja as expected. Would something like this= be OK? --=20 You are receiving this mail because: You are on the CC list for the bug.=