Date: Fri, 15 Jul 2011 15:56:08 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Julien Laffaye <jlaffaye@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Jaap Akkerhuis <jaap@NLnetLabs.nl>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/dns/opendnssec Makefile distinfo pkg-plist ports/dns/opendnssec/files opendnssec.in Message-ID: <4E20C588.5010409@FreeBSD.org> In-Reply-To: <201107152055.p6FKt0ap062328@repoman.freebsd.org> References: <201107152055.p6FKt0ap062328@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------090001010408050008040409 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Jaap, I've attached some (hopefully) improvements to the rc.d script. First the minor issues: 1. It needs a $FreeBSD$ 2. We prefer ports scripts to REQUIRE: LOGIN unless there is a reason it needs to start earlier. 3. Minor typo and whitespace twiddles More substantively, I compressed the start_ and stop_ methods, but this should be tested. It certainly _should_ work. :) It's fine to have all the extra_commands, but they won't be functional unless they also have methods associated with them. Finally, I left the procname assignment in there, but it's not at all clear to me where $opendnssec_procname is defined, or what that procname is going to be used for. It can probably just be deleted. hth, Doug On 07/15/2011 13:55, Julien Laffaye wrote: > jlaffaye 2011-07-15 20:55:00 UTC > > FreeBSD ports repository > > Modified files: > dns/opendnssec Makefile distinfo pkg-plist > Added files: > dns/opendnssec/files opendnssec.in > Log: > Update to 1.3.0 > > PR: ports/158865 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=158865 > Submitted by: Jaap Akkerhuis <jaap@NLnetLabs.nl> (maintainer) > Approved by: bapt (mentor) > > Revision Changes Path > 1.11 +29 -5 ports/dns/opendnssec/Makefile > 1.10 +2 -2 ports/dns/opendnssec/distinfo > 1.1 +42 -0 ports/dns/opendnssec/files/opendnssec.in (new) > 1.6 +2 -1 ports/dns/opendnssec/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/dns/opendnssec/Makefile.diff?&r1=1.10&r2=1.11&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/dns/opendnssec/distinfo.diff?&r1=1.9&r2=1.10&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/dns/opendnssec/files/opendnssec.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/dns/opendnssec/pkg-plist.diff?&r1=1.5&r2=1.6&f=h > -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ --------------090001010408050008040409 Content-Type: text/plain; name="opendnssec.in.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="opendnssec.in.diff" Index: opendnssec.in =================================================================== RCS file: /home/pcvs/ports/dns/opendnssec/files/opendnssec.in,v retrieving revision 1.1 diff -u -r1.1 opendnssec.in --- opendnssec.in 15 Jul 2011 20:55:00 -0000 1.1 +++ opendnssec.in 15 Jul 2011 22:51:59 -0000 @@ -1,16 +1,14 @@ #!/bin/sh -# -# + +# $FreeBSD$ # # PROVIDE: opendnssec -# REQUIRE: DAEMON +# REQUIRE: LOGIN # KEYWORD: shutdown # -# Add the following line to /etc/rc.conf to enable nsd: +# Add the following line to /etc/rc.conf to enable opendnssec: # # opendnssec_enable="YES" -# - . /etc/rc.subr @@ -19,24 +17,17 @@ load_rc_config $name -opendnssec_enable=${opendnssec_enable-"NO"} +opendnssec_enable=${opendnssec_enable:-"NO"} -start_cmd="${name}_start" -stop_cmd="${name}_stop" +start_cmd="${name}_run $1" +stop_cmd="${name}_run $1" extra_commands="reload ksm hsm signer enforcer" procname=${opendnssec_procname} - -opendnssec_start() +opendnssec_run() { - %%PREFIX%%/sbin/ods-control start -} - -opendnssec_stop() -{ - %%PREFIX%%/sbin/ods-control stop + %%PREFIX%%/sbin/ods-control $1 } run_rc_command "$1" - --------------090001010408050008040409--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E20C588.5010409>