Date: Sat, 9 Nov 1996 02:09:21 +0900 (JST) From: Michael Hancock <michaelh@cet.co.jp> To: FreeBSD Hackers <Hackers@FreeBSD.ORG> Subject: queue.h nit again Message-ID: <Pine.SV4.3.95.961109015548.6166A-100000@parkplace.cet.co.jp>
next in thread | raw e-mail | index | archive | help
Gawd, this bugs the crap out of me. Please change the following and
similar in queue.h:
#define TAILQ_ENTRY(type) \
struct { \
struct type *tqe_next; /* next element */ \
struct type **tqe_prev; /* address of previous next element */ \
}
to either ...
#define TAILQ_ENTRY(tag) \
struct { \
struct tag *tqe_next; /* next element */ \
struct tag **tqe_prev; /* address of previous next element */ \
}
or ...
#define TAILQ_ENTRY(type) \
struct { \
type *tqe_next; /* next element */ \
type **tqe_prev; /* address of previous next element */ \
}
The typedef name space and tag name space in are oblivous to each other in
C and confusing the two like this is setting a bad example.
Poul and John prefer the latter. The former has very little impact on the
sources.
Regards,
Mike Hancock
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.SV4.3.95.961109015548.6166A-100000>