From owner-freebsd-hackers  Fri Nov  8 09:09:26 1996
Return-Path: owner-hackers
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id JAA22777
          for hackers-outgoing; Fri, 8 Nov 1996 09:09:26 -0800 (PST)
Received: from parkplace.cet.co.jp (parkplace.cet.co.jp [202.32.64.1])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id JAA22771
          for <Hackers@FreeBSD.ORG>; Fri, 8 Nov 1996 09:09:23 -0800 (PST)
Received: from localhost (michaelh@localhost) by parkplace.cet.co.jp (8.8.2/CET-v2.1) with SMTP id RAA06234 for <Hackers@FreeBSD.ORG>; Fri, 8 Nov 1996 17:09:21 GMT
Date: Sat, 9 Nov 1996 02:09:21 +0900 (JST)
From: Michael Hancock <michaelh@cet.co.jp>
To: FreeBSD Hackers <Hackers@FreeBSD.ORG>
Subject: queue.h nit again
Message-ID: <Pine.SV4.3.95.961109015548.6166A-100000@parkplace.cet.co.jp>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-hackers@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk


Gawd, this bugs the crap out of me.  Please change the following and
similar in queue.h:

#define TAILQ_ENTRY(type)						\
struct {								\
	struct type *tqe_next;	/* next element */			\
	struct type **tqe_prev;	/* address of previous next element */	\
}

to either ...

#define TAILQ_ENTRY(tag)						\
struct {								\
	struct tag *tqe_next;	/* next element */			\
	struct tag **tqe_prev;	/* address of previous next element */	\
}

or ...

#define TAILQ_ENTRY(type)						\
struct {								\
	type *tqe_next;	/* next element */			\
	type **tqe_prev;	/* address of previous next element */	\
}

The typedef name space and tag name space in are oblivous to each other in
C and confusing the two like this is setting a bad example. 

Poul and John prefer the latter.  The former has very little impact on the
sources.

Regards,


Mike Hancock