From owner-cvs-all Sat Sep 5 23:10:09 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id XAA03555 for cvs-all-outgoing; Sat, 5 Sep 1998 23:10:09 -0700 (PDT) (envelope-from owner-cvs-all) Received: from nagual.pp.ru (lsd.relcom.eu.net [193.125.27.73]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA14487; Sat, 5 Sep 1998 21:04:28 -0700 (PDT) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.9.1/8.9.1) id IAA16188; Sun, 6 Sep 1998 08:03:12 +0400 (MSD) (envelope-from ache) Message-ID: <19980906080311.A12205@nagual.pp.ru> Date: Sun, 6 Sep 1998 08:03:11 +0400 From: "Andrey A. Chernov" To: Doug Rabson , Matthew Dillon Cc: John Birrell , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/gen sleep.c Mail-Followup-To: Doug Rabson , Matthew Dillon , John Birrell , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <199809051816.LAA22705@apollo.backplane.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.93.2i In-Reply-To: ; from dfr@nlsystems.com on Sat, Sep 05, 1998 at 09:58:19PM +0100 Organization: Biomechanoid Sender: owner-cvs-all@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Sat, Sep 05, 1998 at 09:58:19PM +0100, Doug Rabson wrote: > On Sat, 5 Sep 1998, Matthew Dillon wrote: > > > The sleep code is totally broken in regards to its comparisons. The > > argument is an unsigned int, but values are stored in time_t which is > > currently a signed long. The code, as it stands, is not clean if either > > time_t changes from signed to unsigned, or if time_t changes from a 32 bit > > value to a 64 bit value. Since there is no harm in doing multiple > > sleeps, why not just fix the code? We no tv_sec must be at least large > > enough to hold INT_MAX, so: > > Looks fine to me. If Andrey agrees, why don't you commit this. Ok for me too. -- Andrey A. Chernov http://www.nagual.pp.ru/~ache/ MTH/SH/HE S-- W-- N+ PEC>+ D A a++ C G>+ QH+(++) 666+>++ Y