From nobody Mon Sep 30 12:11:32 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XHKg90zd2z5YCPD; Mon, 30 Sep 2024 12:11:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XHKg90TRVz4Jk5; Mon, 30 Sep 2024 12:11:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727698293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FQ1oudjSaN+zvegD2jUJrL8AD17xdT3EGsD9D/uJDUI=; b=KssgrJ8eFqKGfMMzhrlaFI0eui9M9iqj8p/w9+H1a9ufVkDeN4T3bjP4BsFxsTbDMW3ik2 KrZ0x+CWEfPvjr+IQW641ZhXl05v7FlJW53IWb3fOwMNFrpsRUEY3AmRxIm93xjbdCFdMe XyIfvDqFLSa3s8WJItP2xxfPGZvPiLIHt1V5HwCHCc9bwLVMkmlTAuVuH3r5YwaFbTvU5X zwSGl8YzlkV758b40cgBLRB0VP5X3sXLUtrIO+I5kmITYDK+vFTqKHBlU2MCmi0P1eDwou ulzqsklgPu2vAFgTQAWddyzsyAssIjo4bjhXFI/JskCJzVlH+mBDkf0LwzNAUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727698293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FQ1oudjSaN+zvegD2jUJrL8AD17xdT3EGsD9D/uJDUI=; b=oNCAl+oYeRvkQNLIUiacYDhnFTTbFwGZZOCRaOBSQ+jFbH7CYS8jC326/VETmkLsKGkN7P nlNj0W1pR0P0he5qm9XjVHMaCv/t7Jn0371b1+TzttywzHqCte5qIPE8jfAuFKq4FhRjIs kNJFF8Qc1Q1wBiWrkfmfFl1Fslpn7tuBv0vPQwh11Ex1czJ32TQaaP1NzOY2cRStPQP3sh a8GQ4Oubcckih3FJKseycew1/Nab8/QyqU56PzALAFTlklXNERbMqxz+zHcYasAo1/XeKB HzNpsiqQLhMF3SYIf9HjaxSYvfbC0iyxbJNqH233lNiWykHXSkH4DVgccEnPVg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727698293; a=rsa-sha256; cv=none; b=bQYKI6cqyWWrsebdj6IaS3aRmEephWPC8R3YQlxRqFT5EWzsheC8g4C2Qak9ds14238uTR 95XxRGI2jQOKtCNZa4DnfOGAET3MlDkknj+CU2jfLHbFECpjV3zesi8bfFUDYd4BJSfUTz jn4S4RfHX51jWXa3yCbUyAky8KReqRPvlf/OmCAzyYWovr2dlFM9cOG4FQ1NxqN8PqoKoW RIXCXb05wNDKJWJmBQf+crQ4DBO374ArxdVgI4tkK0DiCfgWcYqqeSspA4bUWromorwLvS p/D0U4pScTf08qMi+UqdAU8rymDxOdp/SqDBX2h9DAUMv5Wm+iRQ9zToGNWE/w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XHKg872t5zsVB; Mon, 30 Sep 2024 12:11:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 48UCBW2L053349; Mon, 30 Sep 2024 12:11:32 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 48UCBWwY053346; Mon, 30 Sep 2024 12:11:32 GMT (envelope-from git) Date: Mon, 30 Sep 2024 12:11:32 GMT Message-Id: <202409301211.48UCBWwY053346@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: a03acfa43410 - stable/14 - bhyve: initialize register value List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: a03acfa43410b3a449fa8d5b1dbba20e0bf02d5a Auto-Submitted: auto-generated The branch stable/14 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=a03acfa43410b3a449fa8d5b1dbba20e0bf02d5a commit a03acfa43410b3a449fa8d5b1dbba20e0bf02d5a Author: Pierre Pronchery AuthorDate: 2024-07-24 19:33:26 +0000 Commit: Ed Maste CommitDate: 2024-09-30 12:11:15 +0000 bhyve: initialize register value In case of an error in a code pattern like ``` uint64_t val; error = memread(vcpu, gpa, &val, 1, arg); error = vie_update_register(vcpu, reg, val, size); ``` uninitialized stack data would be used. Reported by: Synacktiv Reviewed by: markj Security: HYP-21 Sponsored by: The Alpha-Omega Project Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D46107 (cherry picked from commit 94693ec7c85363f9b0098247489cea3efdb183f9) --- sys/amd64/vmm/vmm_ioport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/amd64/vmm/vmm_ioport.c b/sys/amd64/vmm/vmm_ioport.c index ec270df80c3e..3caea7deac16 100644 --- a/sys/amd64/vmm/vmm_ioport.c +++ b/sys/amd64/vmm/vmm_ioport.c @@ -101,7 +101,7 @@ static int emulate_inout_port(struct vcpu *vcpu, struct vm_exit *vmexit, bool *retu) { ioport_handler_func_t handler; - uint32_t mask, val; + uint32_t mask, val = 0; int error; /*