From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Apr 23 13:50:01 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E2F8D1065675 for ; Thu, 23 Apr 2009 13:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id BCC988FC2E for ; Thu, 23 Apr 2009 13:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n3NDo10E016256 for ; Thu, 23 Apr 2009 13:50:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n3NDo1oT016255; Thu, 23 Apr 2009 13:50:01 GMT (envelope-from gnats) Resent-Date: Thu, 23 Apr 2009 13:50:01 GMT Resent-Message-Id: <200904231350.n3NDo1oT016255@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Justin Hibbits Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9FC511065674 for ; Thu, 23 Apr 2009 13:40:08 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 8D7EB8FC16 for ; Thu, 23 Apr 2009 13:40:08 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n3NDe8xU084845 for ; Thu, 23 Apr 2009 13:40:08 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n3NDe7Tr084843; Thu, 23 Apr 2009 13:40:07 GMT (envelope-from nobody) Message-Id: <200904231340.n3NDe7Tr084843@www.freebsd.org> Date: Thu, 23 Apr 2009 13:40:07 GMT From: Justin Hibbits To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/133949: vim options don't work as expected. X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Apr 2009 13:50:02 -0000 >Number: 133949 >Category: ports >Synopsis: vim options don't work as expected. >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Apr 23 13:50:01 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Justin Hibbits >Release: 8-CURRENT >Organization: >Environment: FreeBSD narn.knownspace 8.0-CURRENT FreeBSD 8.0-CURRENT #16 r191380M: Wed Apr 22 16:53:04 EDT 2009 root@narn.knownspace:/usr/obj/usr/src/sys/NARN powerpc >Description: Two parts: The Vim port breaks ports convention with OPTIONS by requiring WITH_OPTIONS and/or WITH_VIM_OPTIONS, which breaks users' expectations of ports. Also, even when WITH_OPTIONS/WITH_VIM_OPTIONS are enabled configured options don't work at all. >How-To-Repeat: attempt to build the vim port without setting WITH_OPTIONS/WITH_VIM_OPTIONS, and again with. >Fix: Apply attached patch. Patch attached with submission follows: --- Makefile.orig 2009-02-03 14:44:08.000000000 -0500 +++ Makefile 2009-02-03 15:16:49.000000000 -0500 @@ -32,9 +32,7 @@ SLAVEDIRS= editors/vim-lite -.if defined(WITH_OPTIONS) || defined(WITH_VIM_OPTIONS) .include "${.CURDIR}/../vim/options" -.endif CONFLICTS= vim6* vim*-lite USE_BZIP2= yes @@ -57,6 +55,10 @@ .endif MANLANG= "" ru.KOI8-R ru.UTF-8 pl.ISO8859-2 pl.UTF-8 pl fr.ISO8859-1 \ fr.UTF-8 fr it.ISO8859-1 it.UTF-8 it +WANT_PERL= yes +WANT_GNOME= yes + +.include .if defined(PACKAGE_BUILDING) && !defined(LITE) WITH_TCL= yes @@ -82,16 +84,6 @@ USE_TCL_NO_THREADS= yes .endif -.if defined(WITH_PERL) -WANT_PERL= yes -.endif - -.if !defined(WITHOUT_X11) -WANT_GNOME= yes -.endif - -.include - .if !defined(LITE) MAKE_ARGS+= CONF_OPT_FEAT="--with-features=big" I18N= CONF_OPT_MULTIBYTE="--enable-multibyte --enable-fontset --enable-xim" @@ -122,7 +114,7 @@ # for now default the GUI to the GTK+ one # will be reviewed when the GTK+ 1.{3,4} behemoth is released .if !defined(WITH_ATHENA) && !defined(WITH_MOTIF) && !defined(WITH_GNOME) && !defined(WITH_GTK2) -WITH_GNOME= gtk12 +USE_GNOME= gtk12 .endif .if defined(WITH_ATHENA) >Release-Note: >Audit-Trail: >Unformatted: