From owner-svn-ports-all@FreeBSD.ORG Tue Sep 25 15:46:53 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 05E6D1065670; Tue, 25 Sep 2012 15:46:52 +0000 (UTC) Date: Tue, 25 Sep 2012 15:46:52 +0000 From: Alexey Dokuchaev To: Chris Rees Message-ID: <20120925154652.GA18222@FreeBSD.org> References: <201209251523.q8PFNFwb051770@svn.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r304840 - in head/x11: nvidia-driver nvidia-driver-173 nvidia-driver-71 nvidia-driver-96 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2012 15:46:53 -0000 On Tue, Sep 25, 2012 at 04:32:06PM +0100, Chris Rees wrote: > I don't know if a special comment is needed; this is pretty standard slave > behaviour. I'd rather keep it, as nvidia-driver is pretty complicated port(s), and I want it (them) to be documented thoroughly. Almost all patches people send to me miss one or two little things like that. :-( > However, it is a common problem, perhaps we could put a note into the > Porter's Handbook in PORTREVISION or master/slave sections? > > "It is usually incorrect to set PORTREVISION to 0, except in a slave port > where it should override the master port" I would change the last part to "where it should override the one set in the master port". ./danfe