From owner-svn-ports-all@FreeBSD.ORG  Tue Sep 16 06:01:48 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id E04E03FF;
 Tue, 16 Sep 2014 06:01:48 +0000 (UTC)
Received: from mail-la0-x233.google.com (mail-la0-x233.google.com
 [IPv6:2a00:1450:4010:c03::233])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id D5CE6910;
 Tue, 16 Sep 2014 06:01:47 +0000 (UTC)
Received: by mail-la0-f51.google.com with SMTP id gi9so5965063lab.24
 for <multiple recipients>; Mon, 15 Sep 2014 23:01:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=googlemail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=MlhoTCSSxfUYsTe9qzGwql6KHRT+efVvp3X6+3xpmM8=;
 b=LFy247h14e0Jy1BuXQzQ5kPupHXUStylr9zH5ogToca3IaGFwldZQI2hAlNCpJ3aOT
 xepLVU64tRzVN3j740upgKuPlSyUe1Q9vFUyZYGHNCqPpSzroRQqy24vUgz6R5YsBQdV
 HAFsMEMkuwk+sIJgdZx5L5qgVlV6tbrlmNYukF/9rBavARQqMg7o757l5PhMcroo1peh
 NQg39ZRjm/1znU7YwyJNBHAT7mQNEn50izsn5JjXzl9IhkIsx4WOrnrefKrEtqNcLinP
 VMot2iNJ72LmAIR+c4cSsi8Uq5AMoPZUxbroK4wjKNOpwM/M+M2X5Ij913qYnS8cr3Rk
 LNCA==
MIME-Version: 1.0
X-Received: by 10.152.20.132 with SMTP id n4mr8531478lae.86.1410847305799;
 Mon, 15 Sep 2014 23:01:45 -0700 (PDT)
Sender: thomas.e.zander@googlemail.com
Received: by 10.25.31.70 with HTTP; Mon, 15 Sep 2014 23:01:45 -0700 (PDT)
In-Reply-To: <CAJE75NEaUEUssMRoH=JCAGmEeT+rjUunUOAWDnUEpWd=yjuRFA@mail.gmail.com>
References: <201409151453.s8FErDCV032464@svn.freebsd.org>
 <CAJE75NEaUEUssMRoH=JCAGmEeT+rjUunUOAWDnUEpWd=yjuRFA@mail.gmail.com>
Date: Tue, 16 Sep 2014 08:01:45 +0200
X-Google-Sender-Auth: P1JtQEg0SQZ1A7XrKXjlBAgfPns
Message-ID: <CAFU734zqVspP9G=9oJYe3xZ0oL1rOhiZyx0tyOpWJX3tww8zpQ@mail.gmail.com>
Subject: Re: svn commit: r368267 - head/math/gotoblas
From: Thomas Zander <riggs@freebsd.org>
To: "Jason E. Hale" <jhale@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 ports-committers <ports-committers@freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Sep 2014 06:01:49 -0000

On 16 September 2014 02:13, Jason E. Hale <jhale@freebsd.org> wrote:

> I think wrapping OPTIONS_DEFAULT_${ARCH} with ${ARCH} defeats the
> purpose of having OPTIONS_DEFAULT_${ARCH} in the first place.
> Wouldn't simply removing .if defined(PACKAGE_BUILDING)/.endif have
> been enough?

Wrapping is not necessary, you're right. I have removed those.
Removing the PACKAGE_BUILDING would not have been sufficient because
DYNAMIC_ARCH is not supported on machines other than i386 and amd64
and causes build failures there.

Thanks for reporting the issue
Riggs