From owner-cvs-all Tue Apr 30 8:27:12 2002 Delivered-To: cvs-all@freebsd.org Received: from a96180.upc-a.chello.nl (a96180.upc-a.chello.nl [62.163.96.180]) by hub.freebsd.org (Postfix) with ESMTP id EB92837B41C; Tue, 30 Apr 2002 08:27:06 -0700 (PDT) Received: by a96180.upc-a.chello.nl (Postfix, from userid 1001) id 40B5A216D; Tue, 30 Apr 2002 17:27:05 +0200 (CEST) Date: Tue, 30 Apr 2002 17:27:04 +0200 From: Jeroen Ruigrok/asmodai To: "Andrew R. Reiter" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, jeff@freebsd.org Subject: Re: cvs commit: src/share/man/man9 zone.9 Message-ID: <20020430152704.GH66061@daemon.ninth-circle.org> References: <200204301426.g3UEQMk36833@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.28i Organisation: Ninth Circle Enterprises Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG -On [20020430 17:05], Andrew R. Reiter (arr@FreeBSD.org) wrote: >On Tue, 30 Apr 2002, Jeroen Ruigrok van der Werven wrote: >: Log: >: Document uma_zalloc() behaviour. > >You can also pass M_ZERO. That seems illogical for a certain number of reasons: 1. the documentation in the code explicitly only mentions M_WAITOK and M_NOWAIT 2. given the argument's name is `wait', specifying a M_ZERO does not make sense. I sincerely doubt this is what Jeff had in mind, if it works at all. I see the wait is passed is passed from uma_zalloc() to uma_zalloc_internal to slab_zalloc() to the backend supplier routine uma_alloc, which also gets it as wait. As first glance I cannot find any place where using M_ZERO would do what it is documented to do. So feel free to elaborate, but I still hold to my idea that it was not as intended and should be tested against. -- Jeroen Ruigrok van der Werven / asmodai / Kita no Mono asmodai@wxs.nl, finger asmodai@ninth-circle.org http://www.softweyr.com/asmodai/ | http://www.tendra.org/ Beauty is a short-lived reign... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message