From owner-freebsd-emulation@FreeBSD.ORG Wed May 3 08:55:09 2006 Return-Path: X-Original-To: freebsd-emulation@freebsd.org Delivered-To: freebsd-emulation@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E6F6116A401 for ; Wed, 3 May 2006 08:55:09 +0000 (UTC) (envelope-from Alexander@Leidinger.net) Received: from www.ebusiness-leidinger.de (jojo.ms-net.de [84.16.236.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id 27D4143D45 for ; Wed, 3 May 2006 08:55:08 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from Andro-Beta.Leidinger.net (p54A5D811.dip.t-dialin.net [84.165.216.17]) (authenticated bits=0) by www.ebusiness-leidinger.de (8.13.4/8.13.1) with ESMTP id k438krY5004467; Wed, 3 May 2006 10:46:54 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from localhost (localhost [127.0.0.1]) by Andro-Beta.Leidinger.net (8.13.4/8.13.3) with ESMTP id k438sVNr073716; Wed, 3 May 2006 10:54:31 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Wed, 03 May 2006 10:54:31 +0200 Message-ID: <20060503105431.k8rmf62jlwoscwgc@netchild.homeip.net> X-Priority: 3 (Normal) Date: Wed, 03 May 2006 10:54:31 +0200 From: Alexander Leidinger To: Doug Ambrisko References: <200604272148.k3RLmSOm041069@ambrisko.com> In-Reply-To: <200604272148.k3RLmSOm041069@ambrisko.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1) / FreeBSD-4.11 X-Virus-Scanned: by amavisd-new Cc: freebsd-emulation@freebsd.org Subject: Re: Linux emulation enhancement to emulate device nodes and some SCSI stuff X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 May 2006 08:55:10 -0000 Quoting Doug Ambrisko (from Thu, 27 Apr 2006 =20 14:48:28 -0700 (PDT)): > To get the LSI RAID SAS to work under Linux emulation we need to emulate > more of Linux type stuff. I've put patches up at: > =09http://www.ambrisko.com/doug/linux.patches In case you didn't got any responses: go ahead, we don't have an =20 active linuoxlator guru ATM. Some generic comments (only a *quick* C-level review, not a =20 design/concept-level review): ---snip-- @@ -470,7 +522,9 @@ linux_fstat64(struct thread *td, struct #endif =09error =3D kern_fstat(td, args->fd, &buf); +=09translate_fd_major_minor(td, args->fd, &buf); =09if (!error) +=09=09translate_fd_major_minor(td, args->fd, &buf); =09=09error =3D stat64_copyout(&buf, args->statbuf); ---snip--- Bug, missing {} for the "if". Bye, Alexander. --=20 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137 There are two kinds of pedestrians... the quick and the dead. =09=09-- Lord Thomas Rober Dewar