From owner-svn-src-all@freebsd.org Tue Aug 2 15:17:17 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9EF95BAC56F for ; Tue, 2 Aug 2016 15:17:17 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm41-vm9.bullet.mail.bf1.yahoo.com (nm41-vm9.bullet.mail.bf1.yahoo.com [216.109.114.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 568591806 for ; Tue, 2 Aug 2016 15:17:17 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1470150187; bh=C9OeyIU5TU5mqMBtnsNx+PuMRyYmT1UEnnegUvm6OhM=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=Ba/f2phAWoz4VbNtcASuegVSYsVQoUCJPx/yFXo998PTV/XTwOoX556d3/cwc3kTUb2c41kKiihzSG+a4/Rs6g0PLbakyi28m1bzBa3642VV1ZWrX9WG3dy+UTGQjVQRe6nIy5PQBidfGzS/xab0J27g1yt5U4eIA0C9JKv09riinUEUvTarE8RrX7BgV8HLwYv7pdjtM01OhJVkROlMHym3Y6bUY+y8+iR0WXAwLpvi+fa0q/oc5BWHLiHCMa4BRZdw7HUTNRd6Pj2Wie+I+mYfx30ye+xstiWYeNp9bLQx+a7z8B5IWhv1ykk8RN6Y3o4QYOZOc4p6wnkq6k/Vcw== Received: from [66.196.81.172] by nm41.bullet.mail.bf1.yahoo.com with NNFMP; 02 Aug 2016 15:03:07 -0000 Received: from [98.139.211.160] by tm18.bullet.mail.bf1.yahoo.com with NNFMP; 02 Aug 2016 15:03:07 -0000 Received: from [127.0.0.1] by smtp217.mail.bf1.yahoo.com with NNFMP; 02 Aug 2016 15:03:07 -0000 X-Yahoo-Newman-Id: 387660.93581.bm@smtp217.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: oX9878UVM1kz9E0Hw2Af42s1ZJEEcVF.uBpYkAzJQLmD26b 0eN2.6pu_OMYDGnWMykqQYfqEkH1C38ZqGccgfFv4JD.Dox_FM0DXmmatV1o cejNszVmY7PjoD7c4k0kOgw3K9bouYGZ21eDFHBqr8OrRYseHsWzvyPJC8hV Za4g0ejaOP8DQgxNP1Gb9lkrlnwXQQVMjRTjXQeLp7WCJWTgdz3_ZYzO8XcC QTvlvwSNInHHnkBC7alka4Dp.kRcE1TttZRaFGVgqhoKWDttGAGWbUtfY3Kv t9UZlO57Ihqxwm3903gY5HAl_bP0endqBspgTRQNd7iadlg6RhkC0GpnCqhC KY59ulUbGmX52gkNrmQf4NwfZFmv_C.q0_4yTljbf0RkRInT9pbjw8hE4wNP ..240AEVuYeMdPOWUrhlQS6gCw80Q0l6F4vnCuYiFFtTWKfZyaQSBdcvdMvH O4MbjMGU7ka5X3NG.lQWNMOGxfQB._jGsvTbR5AXsckAfPoDxco_u5hhmkiL YVS._XuFhR6Rarz6x3_SAxYjrmdlO9IGPO16DuDG_NkEbOA-- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r303047 - head/usr.bin/sed To: Guido Falsi , Alexey Dokuchaev References: <201607192256.u6JMuewv007503@repo.freebsd.org> <20160802141738.GA84154@FreeBSD.org> <51d8013e-bc4b-a511-306d-0e362a8c3e86@madpilot.net> Cc: svn-src-head@freebsd.org, Mikhail Teterin , svn-src-all@freebsd.org, src-committers@freebsd.org From: Pedro Giffuni Message-ID: <7f8c5c42-7d2f-ffcf-70dd-dbc9d3202ee7@FreeBSD.org> Date: Tue, 2 Aug 2016 10:03:20 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <51d8013e-bc4b-a511-306d-0e362a8c3e86@madpilot.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Aug 2016 15:17:17 -0000 Hello; On 08/02/16 09:54, Guido Falsi wrote: > On 08/02/16 16:17, Alexey Dokuchaev wrote: >> On Tue, Jul 19, 2016 at 10:56:40PM +0000, Pedro F. Giffuni wrote: >>> New Revision: 303047 >>> URL: https://svnweb.freebsd.org/changeset/base/303047 >>> >>> Log: >>> sed(1): Assorted cleanups and simplifications. >>> >>> Const-ify several variables, make it build cleanly with WARNS level 5. >>> >>> Submitted by: mi >>> PR: 195929 >>> MFC after: 1 month >> >> Hi Pedro, >> >> This change causes `games/openttd' to fail now, because the generated >> `$wrkdir/openttd-1.6.1/objs/release/Makefile' file is broken (SRCS var >> is set to bogus value, search for ^SRCS). Reverting usr.bin/sed back >> to r303046 fixes it. >> >> The latest revision (with ngie@'s fix) exhibits the same problem. >> >> Now the port uses somewhat obscure build system, but the sed(1) magic >> happens inside generate_foo() functions using SRC_REPLACE variable set >> in make_sed() inside `config.lib' file; these functions are called by >> the configure script. >> >> Would you or Mikhail mind taking a look? Thanks, > > By chance I had a look at this, thinking it was a local problem on my > machine, and noticed that the substitutions get truncated at exactly > 5120 characters. Looks like some hardcoded 5KiB buffer. > Thank you for the reports, this type of things make nice cases for the test suite. There were good reasons this patch was not meant for 11.0-RELEASE. Given it's the second regression and I am not satisfied with the patch for the first one, I will be reverting the change so we can look at the problems integrally. Pedro.