From owner-svn-src-all@FreeBSD.ORG Tue Dec 31 02:41:13 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D0676565; Tue, 31 Dec 2013 02:41:13 +0000 (UTC) Received: from mail-ie0-x22f.google.com (mail-ie0-x22f.google.com [IPv6:2607:f8b0:4001:c03::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7CCD016D6; Tue, 31 Dec 2013 02:41:13 +0000 (UTC) Received: by mail-ie0-f175.google.com with SMTP id x13so12631996ief.20 for ; Mon, 30 Dec 2013 18:41:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=nVgTfs5Yn3VHY8p9Kcv0aNNUZnp5LRefEgdRmlZTXCU=; b=mtr9Vx5iHoC/ZkxvVC544jDFfSB5lpd8VTe6ugsQfW+0IeeomzE1eh3TH7Xio7LWxx GH2dX26bmVABnLLaggitE2GJEP4+JiqSAzfz74dA3YOCK0fcnEpWoecfkAKjJVdcYDuT kMI4d/Ms1avXgPwRncfVnuGwdlalwjUxfdmJM50MkjQCWTbBgHtRGEzNdQtiFw+QymlB BjtYOjsIOBHfQCzjgNLtk11nFC7p2aKOdhxc64fNw3QOg9nuqSd6B4r5b+ChRoGGGD98 Y6MmYve/mNlHNvYlt7RZKB8FNQeLTlbk1GI3GI5TuYiHofqbtEC8pkkCU6pDbXG6ugzj BUSg== X-Received: by 10.42.4.201 with SMTP id 9mr5425629ict.57.1388457672802; Mon, 30 Dec 2013 18:41:12 -0800 (PST) Received: from charmander.home ([65.95.94.123]) by mx.google.com with ESMTPSA id v2sm60828837igz.3.2013.12.30.18.41.10 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Dec 2013 18:41:11 -0800 (PST) Sender: Mark Johnston Date: Mon, 30 Dec 2013 21:40:34 -0500 From: Mark Johnston To: Gleb Smirnoff Subject: Re: svn commit: r260091 - in head/sys/cddl: contrib/opensolaris/uts/common/dtrace contrib/opensolaris/uts/common/sys dev/dtrace Message-ID: <20131231023952.GA11997@charmander.home> References: <201312301737.rBUHbW3I035088@svn.freebsd.org> <20131230204210.GD71033@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131230204210.GD71033@FreeBSD.org> User-Agent: Mutt/1.5.22 (2013-10-16) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Mike Ma , src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Dec 2013 02:41:13 -0000 On Tue, Dec 31, 2013 at 12:42:10AM +0400, Gleb Smirnoff wrote: > On Mon, Dec 30, 2013 at 05:37:32PM +0000, Mark Johnston wrote: > M> Author: markj > M> Date: Mon Dec 30 17:37:32 2013 > M> New Revision: 260091 > M> URL: http://svnweb.freebsd.org/changeset/base/260091 > M> > M> Log: > M> Now that vmem(9) is available, use vmem arenas to allocate probe and > M> aggregation IDs, as is done in the upstream illumos code. This still > M> requires some FreeBSD-specific code, as our vmem API is not identical to the > M> one in illumos. > M> > M> Submitted by: Mike Ma > > IMHO, alloc_unr() was lighter and thus better for allocating just IDs. That's true; I committed the change since it helps keep our code similar to upstream and, as Pedro notes, it was a long-standing todo item on the wiki. After doing some testing, it looks like vmem is a bit slower: process startup is on the order of tenths of milliseconds longer with this change, for executables containing one USDT probe (since such probes are allocated during process startup). So probably the right thing to do is revert this change. It doesn't actually reduce the upstream diff as much as I'd hoped, anyway. Thanks, -Mark