From owner-freebsd-geom@FreeBSD.ORG Fri Feb 2 13:31:59 2007 Return-Path: X-Original-To: freebsd-geom@freebsd.org Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0D2F016A401 for ; Fri, 2 Feb 2007 13:31:59 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.freebsd.org (Postfix) with ESMTP id 5AF3213C49D for ; Fri, 2 Feb 2007 13:31:56 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 27EE148803; Fri, 2 Feb 2007 14:31:53 +0100 (CET) Received: from localhost (pjd.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 5E3C945683; Fri, 2 Feb 2007 14:31:45 +0100 (CET) Date: Fri, 2 Feb 2007 14:30:56 +0100 From: Pawel Jakub Dawidek To: Ivan Voras Message-ID: <20070202133055.GB21290@garage.freebsd.pl> References: <200702021311.10339.pieter@degoeje.nl> <45C336D7.2060109@fer.hr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/NkBOFFp2J2Af1nK" Content-Disposition: inline In-Reply-To: <45C336D7.2060109@fer.hr> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r804 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: Pieter de Goeje , freebsd-current@freebsd.org, freebsd-geom@freebsd.org Subject: Re: First steps towards importing gvirstor into -current X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Feb 2007 13:31:59 -0000 --/NkBOFFp2J2Af1nK Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 02, 2007 at 02:04:23PM +0100, Ivan Voras wrote: > Pieter de Goeje wrote: > > Hi, I tried the beta3a version from the wiki on an amd64 -CURRENT machi= ne. > > I made some changes (attached) to g_virstor.c and geom_virstor.c to let= them=20 > > compile cleanly on AMD64. Both files contained instances of some printf= =20 > > variant with format "%u" while the parameter was a size_t, so I changed= the=20 > > format to "%zu". > >=20 > > Also, I needed to add -fPIC to the gcc command line to build geom_virst= or.so.=20 > > For some reason, it wasnt able to find "path.h" so I included that one = in the=20 > > search path. >=20 > Yes, I forgot to mention this - no testing was done on anything but i386. >=20 > Thanks for the patches! >=20 > > After successfully building gvirstor (and loading it), I tried to use i= t: > > # ./gvirstor label -s 10000 test /dev/ad0s3b > > Assertion failed: (G_OPT_TYPE(opt) !=3D 0), function parse_arguments,= =20 > > file /usr/src/sbin/geom/core/geom.c, line 272. > > Abort (core dumped) > >=20 > > Basically I'm stuck here. >=20 > Interesting. It seems that the geom main() couldn't parse command line > arguments. I don't know what to make of it. The API for geom(8) command have changed at some point. Where you used G_TYPE_NONE, you should now use G_TYPE_BOOL. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --/NkBOFFp2J2Af1nK Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFFwz0PForvXbEpPzQRAkQgAKCOuqN9+pHrkkDTXMNZLZ5yR/wcZgCdGchk E1y5L02HLJi4smEHVltN67Q= =1UQ7 -----END PGP SIGNATURE----- --/NkBOFFp2J2Af1nK--