From owner-cvs-all@FreeBSD.ORG  Wed Nov  3 12:40:39 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 517DC16A4CE; Wed,  3 Nov 2004 12:40:39 +0000 (GMT)
Received: from kane.otenet.gr (kane.otenet.gr [195.170.0.27])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7B7DD43D3F; Wed,  3 Nov 2004 12:40:38 +0000 (GMT)
	(envelope-from keramida@freebsd.org)
Received: from orion.daedalusnetworks.priv (aris.bedc.ondsl.gr
	[62.103.39.226])iA3CeYrc021253;	Wed, 3 Nov 2004 14:40:36 +0200
Received: from orion.daedalusnetworks.priv (orion [127.0.0.1])
	iA3CeYPx034511;	Wed, 3 Nov 2004 14:40:34 +0200 (EET)
	(envelope-from keramida@freebsd.org)
Received: (from keramida@localhost)iA3CeYRE034510;
	Wed, 3 Nov 2004 14:40:34 +0200 (EET)
	(envelope-from keramida@freebsd.org)
Date: Wed, 3 Nov 2004 14:40:33 +0200
From: Giorgos Keramidas <keramida@freebsd.org>
To: Stefan Farfeleder <stefanf@freebsd.org>
Message-ID: <20041103124033.GA34455@orion.daedalusnetworks.priv>
References: <200411011632.iA1GWA8q030777@repoman.freebsd.org>
	<20041101170748.GA81210@wombat.fafoe.narf.at>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20041101170748.GA81210@wombat.fafoe.narf.at>
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
cc: "David E. O'Brien" <obrien@freebsd.org>
Subject: Re: cvs commit: src/usr.sbin/sysinstall config.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Nov 2004 12:40:39 -0000

On 2004-11-01 18:07, Stefan Farfeleder <stefanf@freebsd.org> wrote:
> On Mon, Nov 01, 2004 at 04:32:10PM +0000, David E. O'Brien wrote:
> > obrien      2004-11-01 16:32:10 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     usr.sbin/sysinstall  config.c
> >   Log:
> >   fix typo in generated /etc/exports: escape all '
>
> > -	    vsystem("echo '# Note that BSD's export syntax is \"host-centric\" vs. Sun\'s \"FS-centric\" one.' >> /etc/exports");
> > +	    vsystem("echo '# Note that BSD\'s export syntax is \"host-centric\" vs. Sun\'s \"FS-centric\" one.' >> /etc/exports");
>
> You need two backslashes here; \' is equivalent to ' inside string literals.

I've discovered after submitting the change David committed that \' is
not enough to quote single quotes in strings quoted with single quotes
too.  The correct quoting would be something like:

vsystem("echo '# Note that BSD'\''s export syntax is \"host-centric\" vs. Sun'\''s \"FS-centric\" one.' >> /etc/exports");

Any chance for a fix of the fix? :-)