From owner-cvs-src@FreeBSD.ORG  Sun Dec  5 22:29:13 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 49ED816A552; Sun,  5 Dec 2004 22:29:12 +0000 (GMT)
Received: from harmony.village.org (rover.village.org [168.103.84.182])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 68B1843D5C; Sun,  5 Dec 2004 22:29:11 +0000 (GMT)
	(envelope-from imp@harmony.village.org)
Received: from localhost (localhost [IPv6:::1])
	by harmony.village.org (8.13.1/8.13.1) with ESMTP id iB5MRIV3041097;
	Sun, 5 Dec 2004 15:27:18 -0700 (MST)
	(envelope-from imp@harmony.village.org)
Date: Sun, 05 Dec 2004 15:27:18 -0700 (MST)
Message-Id: <20041205.152718.41673284.imp@harmony.village.org>
To: phk@phk.freebsd.dk
From: Warner Losh <imp@harmony.village.org>
In-Reply-To: <68311.1102285179@critter.freebsd.dk>
References: <41B388C6.5090409@root.org>
	<68311.1102285179@critter.freebsd.dk>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.ORG
cc: src-committers@FreeBSD.ORG
cc: cvs-all@FreeBSD.ORG
cc: imp@bsdimp.com
cc: nate@root.org
Subject: Re: cvs commit: src/sys/dev/acpica acpi.c 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Dec 2004 22:29:14 -0000

From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
Subject: Re: cvs commit: src/sys/dev/acpica acpi.c 
Date: Sun, 05 Dec 2004 23:19:39 +0100

> In message <41B388C6.5090409@root.org>, Nate Lawson writes:
> >M. Warner Losh wrote:
> >> In message: <200412050135.iB51ZJJl040909@repoman.freebsd.org>
> >>             Nate Lawson <njl@FreeBSD.org> writes:
> >> :   If we are resuming non-MPSAFE drivers, they need Giant held for them.
> >> 
> >> Generally, when walking the device tree, one must have Giant.  I've
> >> been meaning to add asserts for this in the tree...  I think that we
> >> have enough things giant is pushed out of that it is time...
> >
> >I'd like that.  I think the GIANT_REQUIRED asserts should go in the 
> >root_bus suspend/resume/shutdown methods, not in acpi.  This will cover 
> >everyone unless a driver drops Giant and doesn't reacquire it (unlikely).
> 
> In Geom I assert after I call driver methods, just to catch that case
> as well.

Excellent idea...

Warner