From owner-cvs-all Sun Dec 26 1:43:54 1999 Delivered-To: cvs-all@freebsd.org Received: from overcee.netplex.com.au (overcee.netplex.com.au [202.12.86.7]) by hub.freebsd.org (Postfix) with ESMTP id 249F3150D1; Sun, 26 Dec 1999 01:43:16 -0800 (PST) (envelope-from peter@netplex.com.au) Received: from netplex.com.au (localhost [127.0.0.1]) by overcee.netplex.com.au (Postfix) with ESMTP id E4A721CCE; Sun, 26 Dec 1999 17:43:04 +0800 (WST) (envelope-from peter@netplex.com.au) X-Mailer: exmh version 2.1.1 10/15/1999 To: "Daniel C. Sobral" Cc: Bruce Evans , Marcel Moolenaar , Dag-Erling Smorgrav , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 In-Reply-To: Message from "Daniel C. Sobral" of "Sun, 26 Dec 1999 15:43:55 +0900." <3865B92B.B960215F@newsguy.com> Date: Sun, 26 Dec 1999 17:43:04 +0800 From: Peter Wemm Message-Id: <19991226094304.E4A721CCE@overcee.netplex.com.au> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk "Daniel C. Sobral" wrote: > Peter Wemm wrote: > > > > Looking over the -C stuff, I'm not sure why the switch was added. The > > comment marker (two delimter chars at the beginning of a file) wouldn't > > have been legal anyway. strfile doesn't do anything special and the lines > > go in just as normal. IMHO, -C should be removed and the comment check made > > unconditional. > > A flag is setted, just like for rot13'ed things. > > If you have any doubts about it actually working, just test it. I'm not saying that it doesn't work, just that detection of comments should always be "on" and not a switch. rot13 can't be "detected", comments can. Cheers, -Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message