From owner-freebsd-current Thu Sep 5 11:55:55 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 681F937B400 for ; Thu, 5 Sep 2002 11:55:50 -0700 (PDT) Received: from oahu.WURLDLINK.NET (oahu.WURLDLINK.NET [216.235.52.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB8BA43E3B for ; Thu, 5 Sep 2002 11:55:47 -0700 (PDT) (envelope-from vince@oahu.WURLDLINK.NET) Received: from localhost (vince@localhost) by oahu.WURLDLINK.NET (8.11.3/8.11.3) with ESMTP id g85ItOG86219; Thu, 5 Sep 2002 08:55:25 -1000 (HST) (envelope-from vince@oahu.WURLDLINK.NET) Date: Thu, 5 Sep 2002 08:55:24 -1000 (HST) From: Vincent Poy To: Martin Blapp Cc: current@FreeBSD.ORG Subject: Re: Uncommitted dc0 fixes ... In-Reply-To: <20020904165819.R31964-100000@levais.imp.ch> Message-ID: <20020905085204.U2914-100000@oahu.WURLDLINK.NET> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 4 Sep 2002, Martin Blapp wrote: > > Hi all, > > Anybody who can, please commit these PR's. > > 1) dc driver uses wrong case to read MAC from eeprom. > > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=kern/35482 > > > 2) Tulip ether card EN2242 (if_dc.c) use wrong multicast table > > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=misc/32699 > > > 3) ADMtek AN98x, enable automatically TX underrun recovery > > Patch No3 fixes some part of link problem on EN2242 cards. > I've tested this patch and it makes by laptop working again with > cvsup. > > And this patch here together with patch III made the annoying messages (dc0: > failed to force tx and rx to idle mode) go away. And I can use now my card > without to replug the cable over again) > > --- /usr/src/sys/pci/if_dc.c Sun Jun 16 21:36:00 2002 > +++ /usr/src/sys/pci/if_dc.c Wed Sep 4 16:57:23 2002 > @@ -1338,17 +1362,21 @@ > restart = 1; > DC_CLRBIT(sc, DC_NETCFG, (DC_NETCFG_TX_ON|DC_NETCFG_RX_ON)); > > - for (i = 0; i < DC_TIMEOUT; i++) { > - isr = CSR_READ_4(sc, DC_ISR); > - if (isr & DC_ISR_TX_IDLE && > - (isr & DC_ISR_RX_STATE) == DC_RXSTATE_STOPPED) > - break; > - DELAY(10); > - } > + if (DC_IS_INTEL(sc)) { > + for (i = 0; i < DC_TIMEOUT; i++) { > + isr = CSR_READ_4(sc, DC_ISR); > + if (isr & DC_ISR_TX_IDLE && > + (isr & DC_ISR_RX_STATE) > + == DC_RXSTATE_STOPPED) > + break; > + DELAY(10); > + } > > - if (i == DC_TIMEOUT) > - printf("dc%d: failed to force tx and " > - "rx to idle state\n", sc->dc_unit); > + if (i == DC_TIMEOUT) { > + printf("dc%d: failed to force tx and " > + "rx to idle state\n", sc->dc_unit); > + } > + } > } > > Martin Blapp, > ------------------------------------------------------------------ > ImproWare AG, UNIXSP & ISP, Zurlindenstrasse 29, 4133 Pratteln, CH > Phone: +41 061 826 93 00: +41 61 826 93 01 > PGP: > PGP Fingerprint: B434 53FC C87C FE7B 0A18 B84C 8686 EF22 D300 551E > ------------------------------------------------------------------ > > Ups, forgot to add here the PR number ... > 3) ADMtek AN98x, enable automatically TX underrun recovery http://www.FreeBSD.org/cgi/query-pr.cgi?pr=34236 > Patch No3 fixes some part of link problem on EN2242 cards. > I've tested this patch and it makes by laptop working again with > cvsup. When I tried these patches manually handpatching on 08182002 JP SNAPSHOT, it took away the error messages like you had mentioned except I can ping everything except for the gateway. Also, no other protocols would work at all so it seems like something else broke. I took out the following and it still made no difference. http://www.FreeBSD.org/cgi/query-pr.cgi?pr=misc/32699 Cheers, Vince - vince@WURLDLINK.NET - Vice President ________ __ ____ Unix Networking Operations - FreeBSD-Real Unix for Free / / / / | / |[__ ] WurldLink Corporation / / / / | / | __] ] San Francisco - Honolulu - Hong Kong / / / / / |/ / | __] ] HongKong Stars/Gravis UltraSound Mailing Lists Admin /_/_/_/_/|___/|_|[____] Almighty1@IRC - oahu.DAL.NET Hawaii's DALnet IRC Network Server Admin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message