Date: Mon, 09 Dec 2019 21:20:41 +0000 From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 241463] devel/scons: flavor scons for python3 Message-ID: <bug-241463-21822-s9so8ANzuU@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-241463-21822@https.bugs.freebsd.org/bugzilla/> References: <bug-241463-21822@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241463 --- Comment #16 from Ronald Klop <ronald-lists@klop.ws> --- Add a comment with the reply I got in my exp-run request to portmgr@. On Wed, Dec 4, 2019 at 11:01 PM Ronald Klop <ronald-lists@klop.ws> wrote: > > Dear portmgr, > > Is it possible to run an exp-run for https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241463 . > Scons is a build tool for python, so it has quite some dependencies. > > It is the first time I request an exp-run, so please tell if I miss something in my request. Hi, Before an exp-run, this needs to be reviewed / improved / approved by maintainer. Some problems I see: - USES=uniquefiles:dirs seems not needed - USE_PYTHON=flavors seems not needed - PYDISTUTILS_INSTALLARGS is overridden - I don't like the scons arguments, in my opinion it should be 2 or 3, not py27 or py36 Cheers, Antoine Below is the corrected devel/scons diff Index: devel/scons/Makefile =================================================================== --- devel/scons/Makefile (revision 519049) +++ devel/scons/Makefile (working copy) @@ -5,6 +5,7 @@ PORTVERSION= 3.1.1 CATEGORIES= devel python MASTER_SITES= SF +PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} MAINTAINER= sunpoet@FreeBSD.org COMMENT= Build tool alternative to make @@ -14,8 +15,8 @@ RUN_DEPENDS= gm4:devel/m4 -USES= python:2.7 shebangfix -USE_PYTHON= autoplist distutils +USES= python shebangfix +USE_PYTHON= autoplist concurrent distutils NO_ARCH= yes @@ -27,4 +28,8 @@ @${REINPLACE_CMD} -e 's|distutils\(\.command\.install\)$$|setuptools\1|; s|distutils\(\.command\.install\.\)|setuptools\1|' ${WRKSRC}/setup.py @${FIND} ${WRKSRC} -name '*.orig' -delete -.include <bsd.port.mk> +.include <bsd.port.pre.mk> + +PYDISTUTILS_INSTALLARGS+= --standard-lib + +.include <bsd.port.post.mk> -- You are receiving this mail because: You are on the CC list for the bug.help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-241463-21822-s9so8ANzuU>