From owner-svn-src-stable@freebsd.org Sat Mar 4 16:03:07 2017 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 449FECF34F3; Sat, 4 Mar 2017 16:03:07 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id BA3451873; Sat, 4 Mar 2017 16:03:05 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id SAA01372; Sat, 04 Mar 2017 18:03:03 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1ckC99-000C1J-Kg; Sat, 04 Mar 2017 18:03:03 +0200 Subject: Re: svn commit: r314667 - in stable/10/sys: amd64/amd64 cddl/contrib/opensolaris/uts/common/dtrace cddl/contrib/opensolaris/uts/common/fs/zfs cddl/dev/profile compat/ndis contrib/ipfilter/netinet dev/a... To: Julian Elischer , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-stable@FreeBSD.org, svn-src-stable-10@FreeBSD.org References: <201703041303.v24D3Vfi072728@repo.freebsd.org> <1292f504-21e4-1bee-3dd6-6205252bfd26@freebsd.org> From: Andriy Gapon Message-ID: <47d091e5-6efe-5992-f09c-8c231f2da349@FreeBSD.org> Date: Sat, 4 Mar 2017 18:02:02 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1292f504-21e4-1bee-3dd6-6205252bfd26@freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Mar 2017 16:03:07 -0000 On 04/03/2017 17:30, Julian Elischer wrote: > On 4/3/17 9:03 pm, Andriy Gapon wrote: >> Author: avg >> Date: Sat Mar 4 13:03:31 2017 >> New Revision: 314667 >> URL: https://svnweb.freebsd.org/changeset/base/314667 >> >> Log: >> MFC r283291: don't use CALLOUT_MPSAFE with callout_init() >> The main purpose of this MFC is to reduce conflicts for other merges. >> Parts of the original change have already "trickled down" via individual MFCs. > > is there a better name than ''1" when you replace " CALLOUT_MPSAFE"? Maybe 'true'. The argument has type int and it is documented this way: If the mpsafe argument is zero, the callout structure is not considered to be “multi-processor safe”; and the Giant lock will be acquired before calling the callout function and released when the callout function returns. >> - callout_init(&watchdog_callout, CALLOUT_MPSAFE); >> + callout_init(&watchdog_callout, 1); >> if (watchdog_cpu != -1) >> watchdog_change(watchdog_cpu); > -- Andriy Gapon