From owner-svn-src-head@FreeBSD.ORG  Wed Mar  4 20:58:49 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B2D691065672;
	Wed,  4 Mar 2009 20:58:49 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 6D97F8FC2B;
	Wed,  4 Mar 2009 20:58:49 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id n24KtoSS090160;
	Wed, 4 Mar 2009 13:55:50 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Wed, 04 Mar 2009 13:56:06 -0700 (MST)
Message-Id: <20090304.135606.1649768480.imp@bsdimp.com>
To: rnoland@FreeBSD.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200903041823.n24INmcc049524@svn.freebsd.org>
References: <200903041823.n24INmcc049524@svn.freebsd.org>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r189367 - head/sys/dev/pci
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Mar 2009 20:58:50 -0000

In message: <200903041823.n24INmcc049524@svn.freebsd.org>
            Robert Noland <rnoland@freebsd.org> writes:
: Author: rnoland
: Date: Wed Mar  4 18:23:48 2009
: New Revision: 189367
: URL: http://svn.freebsd.org/changeset/base/189367
: 
: Log:
:   Extend the management of PCIM_CMD_INTxDIS.
:   
:   We now explicitly enable INTx during bus_setup_intr() if it is needed.
:   Several of the ata drivers were managing this bit internally.  This is
:   better handled in pci and it should work for all drivers now.
:   
:   We also mask INTx during bus_teardown_intr() by setting this bit.
:   
:   Reviewed by:	jhb
:   MFC after:	3 days

Note: the INTxDIS bit is new in PCI 3.0, and has no effect on earlier
devices.  This should be highlighted in the comments somewhere...

Warner