From owner-svn-src-head@freebsd.org Thu Feb 27 04:36:35 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9E5FE254579; Thu, 27 Feb 2020 04:36:35 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48SfyB4DSGz4LBV; Thu, 27 Feb 2020 04:36:34 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from [192.168.0.3] (unknown [181.52.72.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: pfg) by smtp.freebsd.org (Postfix) with ESMTPSA id CFD45105F8; Thu, 27 Feb 2020 04:36:32 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Subject: Re: svn commit: r358348 - in head/lib/libc: . gdtoa gen sparc64 sparc64/fpu sparc64/gen sparc64/sys sys To: Warner Losh , "Bjoern A. Zeeb" Cc: src-committers , svn-src-all , svn-src-head References: <202002261855.01QIt9Ip040234@repo.freebsd.org> From: Pedro Giffuni Organization: FreeBSD Message-ID: Date: Wed, 26 Feb 2020 23:36:32 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Feb 2020 04:36:35 -0000 On 26/02/2020 18:09, Warner Losh wrote: > > > On Wed, Feb 26, 2020 at 3:47 PM Warner Losh > wrote: > > > > On Wed, Feb 26, 2020 at 12:10 PM Bjoern A. Zeeb > > wrote: > > On 26 Feb 2020, at 18:55, Warner Losh wrote: > > > Author: imp > > Date: Wed Feb 26 18:55:09 2020 > > New Revision: 358348 > > URL: https://svnweb.freebsd.org/changeset/base/358348 > > > > Log: > >   Remove sparc64 specific parts of libc. > > I have a silly question for which it’s long been too late, but > for the > next time .. why do we need a gazillion of commits to remove > sparc64 > rather than 1 “atomic” one (or maybe 2 in case the one missed > a bit) > to remove it all (which would also allow other people to bring > it back > into private trees a lot more easily compared to tracking > changes over > weeks)? > > > One atomic commit is harder and more work for me. > > It's hard to get all the details right before pushing it. It's > hard to develop it as other things in the tree change things which > leads to more conflicts. It can be hard to MFC around (though > these changes won't be MFC'd having too large a commit around them > may generate more conflicts when those things are MFC'd). So I > optimized for my convenience, not others wishing to import it into > their trees. But I'd contend that the delta as far as bringing > back as 10 commits isn't onerous for such a niche demand. > > > Also, if I screw something up, it's easier to back out smaller commits > should that be necessary. Backing out huge commits that remove lots of > things and then reapplying them is tedious and error-prone. Doing it a > little at a time also allows me to make sure that all the CI stuff > works before moving on to the next step. We should/could nevertheless, track the removal process in some PR, or in the Wiki, to make life easier to whomever hero wants to resurrect the changes (not that I see that happening). Pedro.