From owner-freebsd-current Wed Mar 19 19:34: 7 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3585C37B404 for ; Wed, 19 Mar 2003 19:34:05 -0800 (PST) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 286CA43F93 for ; Wed, 19 Mar 2003 19:34:04 -0800 (PST) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (smmsp@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.7/8.12.7) with ESMTP id h2K3Y3FU075236; Wed, 19 Mar 2003 19:34:03 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.7/8.12.7/Submit) id h2K3Y2ij075235; Wed, 19 Mar 2003 19:34:02 -0800 (PST) Date: Wed, 19 Mar 2003 19:34:02 -0800 From: "David O'Brien" To: alasir@supereva.it Cc: current@freebsd.org Subject: Re: buildkernel and gcc2 Message-ID: <20030320033402.GA75080@dragon.nuxi.com> Reply-To: current@freebsd.org Mail-Followup-To: David O'Brien , alasir@supereva.it, current@freebsd.org References: <20030320032113.71826.qmail@web21504.mail.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030320032113.71826.qmail@web21504.mail.yahoo.com> User-Agent: Mutt/1.4i X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Mar 20, 2003 at 03:21:13AM +0000, RMH wrote: > I have to note that currently it isn't really possible to compile > -CURRENT by GCC 2.95.x in the way it has to be. Buildkernel is > broken in several places by different means, however GCC 3.2.x > passes them successfully, even with no warnings shown. Huh?? What do you mean "in the way it has to be"? We purposely upgraded from GCC 2.95.x to 3.2.x and part of that upgrade gave us C99 features. > Namely, first problem is in bsd.kern.mk, because of compiler flag > -mno-align-long-strings, which is not supported by 2.95.x. Should > be autodetected. The patch for doing this? Since the vast majority of 5-CURRENT's users are using the stock 3.2.x compiler, making the kernel build with gcc 2.95.x isn't going to be high on our list of things to do. However, this doesn't prevent you from making a committable patch. > Second problem is periods in two macros of sys/eventhandler.h, > that broke depend: > > #define EVENTHANDLER_FAST_INVOKE(name, ...) > #define EVENTHANDLER_INVOKE(name, ...) > > Might be fixed in the way like: > > #define EVENTHANDLER_FAST_INVOKE(name) > #define EVENTHANDLER_INVOKE(name, arg1, arg2, arg3) We can certainly put in a #ifdef detection on the GCC version. Please submit a patch for this and the other nits you point out. > ../../../kern/vfs_bio.c:3514: warning: unknown conversion type character `j' in > format > ../../../kern/vfs_bio.c:3514: warning: unknown conversion type character `j' in > format > [...] > > Please replace those j's for something more appropriate; I've > just removed them. Accompanying typedefs uintmax_t\intmax_t > were replaced with u_int\int. "%j" and [u]intmax_t *are* appropriate. They are C99 features, and most find them a god-send. > Summary. Since I have no write access to CVS repository, hope > someone who has will consider things noted above and commit > changes. Not being a committer doesn't keep you from being a contributor. :-) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message