From owner-cvs-all@FreeBSD.ORG Wed May 23 18:14:04 2012 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7064A106567C for ; Wed, 23 May 2012 18:14:04 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com [209.85.210.54]) by mx1.freebsd.org (Postfix) with ESMTP id 28F8F8FC1D for ; Wed, 23 May 2012 18:14:03 +0000 (UTC) Received: by dadv36 with SMTP id v36so10924094dad.13 for ; Wed, 23 May 2012 11:14:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:x-operating-system:organization:x-living-the-dream :x-pgp-fingerprint:x-pgp-key:user-agent:x-gm-message-state; bh=EC7DWPzxrjRE7RaE/oDTKCdbN7nTr0m7FR7xBE/lSkk=; b=hhF5ERzlalVK8cKjJm2E0nHFbF1WxNtJdVPJ1AU0qbLV75U/LqXuPLkWTM+f5MTPam U0GI3n9DD5Wm7h5Km4YlFIbnzKMkTCesxmHYSN7OITa4DFl1KWnkAhrvWaY6W/i/koiW ofOaMW6qsQ0+Qewe3EB9uUDCytLsjYXHKCUPpE0ht852ESyu1V4dOXZ048yP8lyiRGYi 7w11jDnxo2L51FjQB10P5toUAUCphrZjI04cPgu3BMCcu2p8Vy+mZHhdCfjYXHeB6t6o cogQh4SiFqoKDMis+TiYeV2HC2RldlQgWHTxUAsRFOIgbVAwYCzjTTUFo+N1JGt9PmXG RKfw== Received: by 10.68.233.193 with SMTP id ty1mr12678135pbc.47.1337796843619; Wed, 23 May 2012 11:14:03 -0700 (PDT) Received: from dormouse.experts-exchange.com ([72.29.164.238]) by mx.google.com with ESMTPS id mr6sm2578220pbb.29.2012.05.23.11.14.01 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 23 May 2012 11:14:02 -0700 (PDT) Sender: Jason Helfman Date: Wed, 23 May 2012 11:12:41 -0700 From: Jason Helfman To: Chris Rees Message-ID: <20120523181241.GI8317@dormouse.experts-exchange.com> References: <201205231334.q4NDYCMQ078804@repoman.freebsd.org> <1337780396.2024.2.camel@pav.hide.vol.cz> <9b15e44319f017bff90bc3caa1de79d9@bluelife.at> <1337781238.2024.7.camel@pav.hide.vol.cz> <1337781346.2024.8.camel@pav.hide.vol.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: FreeBSD 8.3-RELEASE amd64 Organization: The FreeBSD Project, http://www.freebsd.org X-Living-The-Dream: I love the SLO Life! X-PGP-FingerPrint: 8E0D C457 9A0F C91C 23F3 0454 2059 9A63 4150 D3DC X-PGP-Key: http://people.freebsd.org/~jgh/jgh.asc User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQn6JIvtW4y6NZ9asDwMZD854kQbRXuVhlYlKXjEckgo+QPB9sLR/VHhteqPZtDmfRRxYXeS Cc: Martin Wilke , cvs-all@freebsd.org, ports-committers@freebsd.org, Pav Lucistnik , cvs-ports@freebsd.org, Bernhard Froehlich Subject: Re: cvs commit: ports/databases/pg_filedump Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2012 18:14:04 -0000 On Wed, May 23, 2012 at 07:04:52PM +0100, Chris Rees thus spake: >On 23 May 2012 15:39, Bernhard Froehlich wrote: >> On 23.05.2012 15:55, Pav Lucistnik wrote: >>> >>> Pav Lucistnik píše v st 23. 05. 2012 v 15:53 +0200: >>>> >>>> Bernhard Froehlich píše v st 23. 05. 2012 v 15:47 +0200: >>>> > On 23.05.2012 15:39, Pav Lucistnik wrote: >>>> > > Martin Wilke píše v st 23. 05. 2012 v 13:34 +0000: >>>> > >> miwi        2012-05-23 13:34:12 UTC >>>> > >> >>>> > >>   FreeBSD ports repository >>>> > >> >>>> > >>   Modified files: >>>> > >>     databases/pg_filedump Makefile >>>> > >>   Log: >>>> > >>   - Switch to FETCH_DEPENDS to fix fetch during build >>>> > > >>>> > > How is this supposed to work? The log message makes no sense. >>>> > >>>> > The problem that this fixes is when you are building in jails >>>> > and restrict internet access to the "fetch" target like >>>> > pointyhat-west, redports.org and poudriere already do. >>>> >>>> Well, the restriction was put in place for a reason 1*), and now you're >>>> working around that very reason. So just remove the restriction from >>>> pointyhat and problem solved. >>> >>> >>> On a second read, now I see what you're achieving. But still, the chosen >>> solution seems suboptimal. >> >> >> On the list of broken ports there are a handful of ports (including this >> one) that depend on another ports code (aka working directory). Right now >> those ports are written using a dirty hack like that: >> >> from databases/mysql-q4m: >> >> BUILD_DEPENDS= >>  ${NONEXISTENT}:${PORTSDIR}/databases/mysql${MYSQL_VER}-server:build >> CONFIGURE_ARGS= --with-mysql="$$(cd >> ${PORTSDIR}/databases/mysql${MYSQL_VER}-server; ${MAKE} -V WRKSRC)" >> >> We decided to choose the s/BUILD_DEPENDS/FETCH_DEPENDS/ solution because >> it doesn't actually make the hack much worse than it already is. The >> downside is that it builds during fetch which isn't nice but better than >> fetch during build which is a security improvement. >> >> If someone comes up with a better solution without completely rewriting >> all those ports I would be glad to help doing it. Right now it looks like >> there are around 5-10 ports of that kind. > >I'm deeply unhappy about adding ad-hoc fixes like this. > >Any comments about [1]? I do think that the fixes already put in >should be reverted in favour of a proper solution. > >Alternatively something like (but more hackish): > >.for dep in ${PKG_DEPENDS} ${EXTRACT_DEPENDS} ${PATCH_DEPENDS} >${BUILD_DEPENDS} ${LIB_DEPENDS} ${RUN_DEPENDS} ># Check any dependencies with third tuple full, but don't duplicate. >. if !empty(dep:M*\:*\:*) && >empty(FETCH_DEPENDS:M*\:${dep:C,[^:]*\:([^:]*)\:[^:]*,\1}:\*) >FETCH_DEPENDS+= ${dep:C,[^:]*$,fetch} >. endif >.endfor > >Which is better? > >Chris > >==== > >[1] http://www.bayofrum.net/~crees/patches/bsd.port.mk-fetch-depends.diff When I first ported databases/jasperserver, I was told by Pav that it couldn't be on pointyhat because it fetched post-fetch. I worked with the vendor to provide a solution that provided the same files that could be verified, while not compromising the build. Is there any reason that these projects should be allowed to fetch post-fetch? -jgh -- Jason Helfman FreeBSD Committer | http://people.freebsd.org/~jgh | The Power To Serve