From owner-svn-src-all@FreeBSD.ORG  Wed Apr 18 02:16:25 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 929201065675;
	Wed, 18 Apr 2012 02:16:25 +0000 (UTC)
	(envelope-from peterjeremy@acm.org)
Received: from mail16.syd.optusnet.com.au (mail16.syd.optusnet.com.au
	[211.29.132.197])
	by mx1.freebsd.org (Postfix) with ESMTP id F10388FC16;
	Wed, 18 Apr 2012 02:16:24 +0000 (UTC)
Received: from server.vk2pj.dyndns.org
	(c220-239-251-180.belrs5.nsw.optusnet.com.au [220.239.251.180])
	by mail16.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	q3I2GGr2025345
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Wed, 18 Apr 2012 12:16:17 +1000
X-Bogosity: Ham, spamicity=0.000000
Received: from server.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1])
	by server.vk2pj.dyndns.org (8.14.5/8.14.4) with ESMTP id q3I2GFxQ068667;
	Wed, 18 Apr 2012 12:16:15 +1000 (EST)
	(envelope-from peter@server.vk2pj.dyndns.org)
Received: (from peter@localhost)
	by server.vk2pj.dyndns.org (8.14.5/8.14.5/Submit) id q3I2GF62068664;
	Wed, 18 Apr 2012 12:16:15 +1000 (EST) (envelope-from peter)
Date: Wed, 18 Apr 2012 12:16:14 +1000
From: Peter Jeremy <peterjeremy@acm.org>
To: Andrew Thompson <thompsa@FreeBSD.org>
Message-ID: <20120418021614.GA37269@server.vk2pj.dyndns.org>
References: <201204180139.q3I1dEPZ008424@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="xHFwDpU9dbj6ez1V"
Content-Disposition: inline
In-Reply-To: <201204180139.q3I1dEPZ008424@svn.freebsd.org>
X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r234403 - head/sys/net
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Apr 2012 02:16:25 -0000


--xHFwDpU9dbj6ez1V
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2012-Apr-18 01:39:14 +0000, Andrew Thompson <thompsa@FreeBSD.org> wrote:
>Log:
>  Remove KASSERTS, they do not add any value here since the pointer is abo=
ut to
>  be derefernced anyway.

Could you give a bit more background to this commit.  You get a crash in
both cases but the KASSERT() at least tells you which variable was NULL
without needing to trawl through the crashdump to find what caused the
NULL pointer dereference trap.

--=20
Peter Jeremy

--xHFwDpU9dbj6ez1V
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAk+OI+4ACgkQ/opHv/APuIe/lgCeIrbn2hu/S8ycTqu9d9vRPdnE
vEAAn32jtvIzlauomHYzInuwJbFfyUBB
=sL1q
-----END PGP SIGNATURE-----

--xHFwDpU9dbj6ez1V--