From owner-cvs-all@FreeBSD.ORG Tue Oct 30 04:26:55 2007 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A603E16A417 for ; Tue, 30 Oct 2007 04:26:55 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.178]) by mx1.freebsd.org (Postfix) with ESMTP id 794E113C4B8 for ; Tue, 30 Oct 2007 04:26:55 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: by wa-out-1112.google.com with SMTP id k17so2408320waf for ; Mon, 29 Oct 2007 21:26:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=RAsTBKjnsyoGD1z+p7+McJ0RrrAD+7sVWyS6bnKsMJo=; b=H+YN6TV1VFsvbEGANCBtBt+xZbvkA34RZvY2jryqGUY6PStI/SrAtDyfybc01zotZBHqdqoW2RrHxlH34eOne4WqWroa9hy47nmg0dVCkh0x+m76SNNunz/98MmMHl46VQflEo65jNuJLsSoENLsUai1DaQkkm0IXP8r9FYLXsk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=FPXZWsRrANV56p6VuEYAIWAV0lMsQG3OXUOCGg3XMyhbyJiXE8mwOXsU/oRHmWPgC/ZtKXI+2jGxjF/z64hB7mY6mkxgyfGrdwM/k94+8QdyBiH4HKebxQ/3vVcu+2D353YcLB7pNcUgPZ+vIEle0g86QuY2nY34RbqQ3W5gTM0= Received: by 10.115.77.1 with SMTP id e1mr5156182wal.1193716842470; Mon, 29 Oct 2007 21:00:42 -0700 (PDT) Received: by 10.114.13.15 with HTTP; Mon, 29 Oct 2007 21:00:42 -0700 (PDT) Message-ID: Date: Mon, 29 Oct 2007 21:00:42 -0700 From: "Kip Macy" To: "David Xu" In-Reply-To: <47269AD0.3080906@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200710292101.l9TL1mAE049561@repoman.freebsd.org> <47268F17.1000106@freebsd.org> <47269AD0.3080906@freebsd.org> Cc: Daniel Eischen , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libthr/thread thr_mutex.c src/lib/libkse/thread thr_mutex.c src/include pthread.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Oct 2007 04:26:55 -0000 On 10/29/07, David Xu wrote: > Daniel Eischen wrote: > > On Tue, 30 Oct 2007, David Xu wrote: > > > >> I am not sure PTHREAD_MUTEX_ADAPTIVE_NP is a correct solution, in fact > >> I think this is Linux crap, shouldn't PTHREAD_PRIO_PROTECT and > >> PTHREAD_PRIO_INHERIT mutex be adaptivly spinned ? > >> also this commit does not change mutex_self_lock() to handle the > >> PTHREAD_MUTEX_ADAPTIVE_NP, what is the PTHREAD_MUTEX_ADAPTIVE_NP > >> definition when the mutex is already locked by the currect thread ? > >> deadlock or return error code ? > > > > > > I tend to agree with the "Linux crap" comment, but I hesitate > > to use those words considering the recent sensor framework > > incident ;-) > > Perhaps. I'm sure Kris would welcome you working more closely with him in his tuning efforts. We should all be thankful both that you're working on libthr and that Kris has put so much time into making FreeBSD a better performing platform. -Kip