From owner-cvs-usrsbin  Mon Sep  9 07:46:37 1996
Return-Path: owner-cvs-usrsbin
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id HAA24088
          for cvs-usrsbin-outgoing; Mon, 9 Sep 1996 07:46:37 -0700 (PDT)
Received: from luke.pmr.com (luke.pmr.com [206.224.65.132])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id HAA24073;
          Mon, 9 Sep 1996 07:46:33 -0700 (PDT)
Received: (from bob@localhost) by luke.pmr.com (8.7.5/8.7.3) id JAA05306; Mon, 9 Sep 1996 09:46:31 -0500 (CDT)
From: Bob Willcox <bob@luke.pmr.com>
Message-Id: <199609091446.JAA05306@luke.pmr.com>
Subject: Re: cvs commit:  src/usr.sbin/newsyslog newsyslog.c
To: jkh@freefall.freebsd.org (Jordan K. Hubbard)
Date: Mon, 9 Sep 1996 09:46:31 -0500 (CDT)
Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org,
        cvs-usrsbin@freefall.freebsd.org
In-Reply-To: <199609060636.XAA29293@freefall.freebsd.org> from "Jordan K. Hubbard" at "Sep 5, 96 11:36:13 pm"
X-Mailer: ELM [version 2.4ME+ PL22 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-usrsbin@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

Jordan K. Hubbard wrote:
> jkh         96/09/05 23:36:12
> 
>   Modified:    usr.sbin/newsyslog  newsyslog.c
>   Log:
>   PR#2724 in NetBSD notes that newsyslog save log files even if the number
>   of copies to save is zero.  Incorporate suggested fix with some stylistic
>   cleanup to make the resulting code more readable.
>   Submitted-By: Kenneth Stailey <kstailey@dol-esa.gov>
>   
>   Revision  Changes    Path
>   1.6       +15 -6     src/usr.sbin/newsyslog/newsyslog.c
> 

This change breaks newsyslog (on my system, anyway).  Now, newsyslog
will never rename /var/log/maillog to /var/log/mailog.0 (for example).

The problem with the above change is that when numdays is -1 the
rename will be skipped.  Unfortunately, numdays will *always* be
-1 at the termination of the while loop which precedes the changes.
:-(

Thanks,
-- 
Bob Willcox	       politics, n:
bob@luke.pmr.com         A strife of interests masquerading as a contest of
Austin, TX               principles.  The conduct of public affairs for private
                         advantage.       -- Ambrose Bierce