From owner-dev-commits-src-main@freebsd.org Fri May 7 16:15:36 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7B820634385 for ; Fri, 7 May 2021 16:15:36 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FcFt02kQrz4p2f for ; Fri, 7 May 2021 16:15:36 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-qt1-x829.google.com with SMTP id a18so6959827qtj.10 for ; Fri, 07 May 2021 09:15:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=hEfmu+L2ScybVLkkZMBru71ORVLkfj3oOBzO5vXCi+M=; b=jTCFC5aQVeKDP9RYXbMukHdntBAZXEMcfW2J+9N5rvR5ssf1C4rYek9mCZcbaOdbNV EB45HUmsvEEm1/9B4m3AqpDGhqLHQ/v/1bfolRqrx+V/IbZXIhZ1GGQdoOp05DeDZXVQ FJbUuFsWv622F1cw7pTz3hmtdealmylQIDBeZgVPe89vXZcLr4Cup0yqGSE2Z8Xtqt7I WLExQejR6mSAzHg9Pw+qYl9s9Luajtx/nBGUd9UcYgjzHR8YyJt9P/j6zQqNOOmKUF5X WjsGi7GEA2HWq4vXbYMPTp5RmABSimQlWZv4VNsTvX754Dv620l4o7ik4jc0LXzHfb8S ES+w== X-Gm-Message-State: AOAM533WXiBeoPlBFLuasF/Ir7ormR90vARqMSnwAfZEg6RjtzMupKKQ vBfLs0pKBP0YYCaKK3uAfhF7yA== X-Google-Smtp-Source: ABdhPJzPxlh2Kw4zYokIq2PeSv34wtsSnC4JCi4phXsNjIzFmCohUEBhcaSgsolyQADBdnsEC0TqSw== X-Received: by 2002:a05:622a:342:: with SMTP id r2mr10045722qtw.232.1620404135043; Fri, 07 May 2021 09:15:35 -0700 (PDT) Received: from smtpclient.apple ([2607:fb10:7061:101::a]) by smtp.gmail.com with ESMTPSA id m4sm5644028qtg.21.2021.05.07.09.15.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 May 2021 09:15:31 -0700 (PDT) From: Randall Stewart Message-Id: Content-Type: multipart/signed; boundary="Apple-Mail=_10B982D7-AFF2-4A02-8E26-E97DEEEEB8F0"; protocol="application/pkcs7-signature"; micalg=sha-256 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.80.0.2.43\)) Subject: Re: git: 5d8fd932e418 - main - This brings into sync FreeBSD with the netflix versions of rack and bbr. This fixes several breakages (panics) since the tcp_lro code was committed that have been reported. Quite a few new features are now in rack (prefecting of DGP -- Dynamic Goodput Pacing among the largest). There is also support for ack-war prevention. Documents comming soon on rack.. Date: Fri, 7 May 2021 12:15:28 -0400 In-Reply-To: Cc: Michael Tuexen , Li-Wen Hsu , Randall Ray Stewart , src-committers , "" , dev-commits-src-main@freebsd.org To: "M. Warner Losh" References: <202105061526.146FQS0E008755@gitrepo.freebsd.org> X-Mailer: Apple Mail (2.3654.80.0.2.43) X-Rspamd-Queue-Id: 4FcFt02kQrz4p2f X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 May 2021 16:15:36 -0000 --Apple-Mail=_10B982D7-AFF2-4A02-8E26-E97DEEEEB8F0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Yep We either need to change it and add ifdefs=E2=80=A6 or make it a requirement like TCP_HTPS Let me go look at what makes sense R > On May 7, 2021, at 12:11 PM, Warner Losh wrote: >=20 >=20 >=20 > On Fri, May 7, 2021 at 5:10 AM Michael Tuexen = wrote: > > On 7. May 2021, at 11:39, Li-Wen Hsu wrote: > >=20 > > On Thu, May 6, 2021 at 11:26 PM Randall Stewart = wrote: > >>=20 > >> The branch main has been updated by rrs: > >>=20 > >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D5d8fd932e418f03e98b3469c4088a36f= 0ef34ffe > >>=20 > >> commit 5d8fd932e418f03e98b3469c4088a36f0ef34ffe > >> Author: Randall Stewart > >> AuthorDate: 2021-05-06 15:22:26 +0000 > >> Commit: Randall Stewart > >> CommitDate: 2021-05-06 15:22:26 +0000 > >>=20 > >> This brings into sync FreeBSD with the netflix versions of rack = and bbr. > >> This fixes several breakages (panics) since the tcp_lro code was > >> committed that have been reported. Quite a few new features are > >> now in rack (prefecting of DGP -- Dynamic Goodput Pacing among = the > >> largest). There is also support for ack-war prevention. = Documents > >> comming soon on rack.. > >>=20 > >> Sponsored by: Netflix > >> Reviewed by: rscheff, mtuexen > >> Differential Revision: https://reviews.freebsd.org/D30036 > >=20 > > This seems braking LINT kernel build of powerpc: > >=20 > > https://ci.freebsd.org/job/FreeBSD-main-powerpc-LINT/6082/console > >=20 > > Searching "error:" leads to: > >=20 > > 00:08:15.153 = /workspace/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:214= 3:16: > > error: implicit declaration of function 'tcp_hw_highest_rate' is > > invalid in C99 [-Werror,-Wimplicit-function-declaration] > > 00:08:15.153 high_rate =3D > > tcp_hw_highest_rate(rack->r_ctl.crte); > > 00:08:15.153 ^ > >=20 > > and > >=20 > > 00:08:15.163 = /workspace/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:216= 5:16: > > error: implicit declaration of function 'tcp_hw_highest_rate_ifp' is > > invalid in C99 [-Werror,-Wimplicit-function-declaration] > > 00:08:15.163 high_rate =3D > > tcp_hw_highest_rate_ifp(rack->rc_inp->inp_route.ro_nh->nh_ifp, > > rack->rc_inp); > > 00:08:15.163 ^ > >=20 > > I suspect this is because RATELIMIT is not defined in default = powerpc > > build? Is it safe to enable it? > If you are building TCP stacks, you need RATELIMIT. You can enable it. = It is enabled on > other platforms, too. >=20 > Yea. If we can't enable it on powerpc, I have some ideas on how to = keep these modules > from building when RATELIMIT isn't enabled. >=20 > Warner=20 ------ Randall Stewart rrs@netflix.com --Apple-Mail=_10B982D7-AFF2-4A02-8E26-E97DEEEEB8F0 Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCAzYw ggMyMIICGqADAgECAgqxywKqrHPB2ybTMA0GCSqGSIb3DQEBCwUAMEcxGDAWBgNVBAMTD1JhbmRh bGwgU3Rld2FydDEeMBwGCSqGSIb3DQEJARYPcnJzQG5ldGZsaXguY29tMQswCQYDVQQGEwJVUzAe Fw0yMTAxMjQxMjIwMTRaFw0yNjAxMjQxMjIwMTRaMEcxGDAWBgNVBAMTD1JhbmRhbGwgU3Rld2Fy dDEeMBwGCSqGSIb3DQEJARYPcnJzQG5ldGZsaXguY29tMQswCQYDVQQGEwJVUzCCASIwDQYJKoZI hvcNAQEBBQADggEPADCCAQoCggEBAMUAht2nr/NFlK+tmmN9PdO3DBPfeYh9fLcbVihR+/dipO41 AsFy9y+2uDVaFhTEvp406P0o9PQQTuYXqrCr76eWQIj3V787e1WKjTup1mIyQeWHGf1gvb/7vmI2 zHg6QZEIC4W8xeO8SLKyHiwlFHZn8Rn1HxtB7Ge+NulygkgUgJYhXD5E29jVGXAc6Qn9Vr9AexPf KaOhHCaNB/Twcinayz6D8CO/Ym1LOs3+ceSOa4cB07fepmbqDSXDkOeA3U7KLaluHrRTlj6DO+JU nqKXX7jJ68KTYSZ0qH4fZsk8cxFkwYI/3HDJi+oF+FDkf7SRo1Q2w+e3M/5MReLIQ7sCAwEAAaMg MB4wDwYJKoZIhvcvAQEKBAIFADALBgNVHQ8EBAMCB4AwDQYJKoZIhvcNAQELBQADggEBAHJfum1j 1WIVFjOJT/hqMIN751aXkablmwesW94lNJKjslPULbbcP5nZGg2lGpHcZ+0I5F/1TTiEsT2H2rhA uAnSsUxTpxRA+aoe+xtJOa5vle3CprhFkHAvB7EIoLiNaPd0DNK6kKYsbvr5Z5Eq7TF3SIO77Qh9 /8VgUfOb0ARDgix59Q6MM0NmIabEwh0cDWQYlGgDDtN9DNk5PGM4pjs48suwEdLmFTMOmGTkCp7I Vq6iHDNinBiB6+BB4VYMAO1o9qS+0pnfdmPJybt0zVGrhm/c1Fmm3Jec7NEuiKeXmhPIwdwMkKyp AsX0sHuFCYwioBTHHZpvnir+H2rRakgxggHrMIIB5wIBATBVMEcxGDAWBgNVBAMTD1JhbmRhbGwg U3Rld2FydDEeMBwGCSqGSIb3DQEJARYPcnJzQG5ldGZsaXguY29tMQswCQYDVQQGEwJVUwIKscsC qqxzwdsm0zANBglghkgBZQMEAgEFAKBpMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZI hvcNAQkFMQ8XDTIxMDUwNzE2MTUyOFowLwYJKoZIhvcNAQkEMSIEIJoXMYeXpEDo2wtKN4VfON1Q 5mHKFPN8O+2H/qvYCTx5MA0GCSqGSIb3DQEBCwUABIIBAJWQ+z8w+1LVgYj7+Q+OtEZBbLLfM/R3 t9uSKBdZBTIdCAYPHZXGN64K8GPWjkFrWY5IsmKB3xfplBzRysU14mvbwmRoYPU6n7raSbmSdIF3 9RzmPTinzFSaPwo9UDnE0acC0ovL38Sf5fXEeCEqoW3sNOL8LYdFDDbyx5Jl4srqiQEAT2yRPfGj lfszMPXHjTwxkUnSkieJBuCW96Vf2O22sYAAoZZNAGGDhrjhg134bSzP79g+55X8bZxRgU611hc1 WVTqCSvmlCLV8k9BcwQ+JhhUWIwFWUmRlxrlvLtJXiKrWkh+tXIYjgGzJQ9WFbMGYD1PuDdBiGpb vT3AHCEAAAAAAAA= --Apple-Mail=_10B982D7-AFF2-4A02-8E26-E97DEEEEB8F0--