From nobody Wed Aug 9 17:20:31 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RLcJb2dnpz4Txk5; Wed, 9 Aug 2023 17:20:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RLcJb25C5z3P6h; Wed, 9 Aug 2023 17:20:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691601631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gmwP78/yLbhppjWNpiLCUcXOYNuwTSIbcMcjPN3N8Tg=; b=p5CONoJvtgOS1Yof09TYFhcZZ9Vh2RuNuY1B87eQfP1M2GBm22fNmmNGuZOxee0KkwyVHS A+OBfiush5xaF+f/PyPT7ZUPjUXQtERHJv1mLhgKe2r6i10+7GG9pDBcHMI31BzlzDUldq KihMFtCodKMbeeuEvKNpY/2AJaWAb+D1lFPxCMK0ecZBqjR2PacZPCFe7kDLIV9HjmH1c1 ZofHOsRkxnEPLsLWmuBM+nFeCKaDM8VlF0Kxi2Gi8/P1wyxjBijfRWnnwz8Zx1CJRjPuCJ wx6FiDYVzemCLfRAw6XlhQDa2a5X3O/mwzaShIbcPeN+LOq5yYsESznuuQ8aeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691601631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gmwP78/yLbhppjWNpiLCUcXOYNuwTSIbcMcjPN3N8Tg=; b=e/zUwyvQ+jCGAr+t7lxFeZRohAfDqyU41gM8Qr+koXcevxHUgWR8LZuiiTe8d/v54Ld467 XLVEgkL5heewQaz6ytyxH1SPmArOWZ4InTRHWCXXj15XhWKe7FXcXUS3flqXeDTi8ap4N9 Ut19FT+rF16+TxVqd3c8on/o3poEhfjOvHg+Ew0fQQrENK8/lS02EtVPrwlar56ZYww0R/ P1jqjqRYvbwteqvXWSCaBIOmcBbHICVfCEyMbx5CA8Aff4fSAkmxHtLUu9Nz+f68BXwZRd fAgKnD5HuJ+0qDmzhkJhJic8Hh9yaAcGzHf9+gBCyQiwHRVAS0TVvrsU+BsaIw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1691601631; a=rsa-sha256; cv=none; b=XEJCibUjdTXASBXcg4i8W6JxprBKjS1vpwQ/PRlEv1x1HggtUW1zVgbz1xaxmCCULiawCo ME2hvkcYMKsyh06LATXTz2gcM2YuajUKh2eS038M/qtCehhhAyvMkNSa8FeN6o0twKRNXc sE4dToEOt20kX7ycyGVZoTpmFrwz6mDLmdpVuor45ibcDskAH9fxlVLGO9ENt6W6tiV/5J DG+NHHhmvwOHcvGccVFxM9MqNH4gnRa1Z8ReaeEoN5/MYFa0z6YbqDJU0MbFjf/asZ5jGJ V8AghlA3crnOHAsO2EsR/J3UsuKnrscb7MHWwAlqeAss4CthYMmGr7QhIFlulw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RLcJb17Zfz8TR; Wed, 9 Aug 2023 17:20:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 379HKVHo019972; Wed, 9 Aug 2023 17:20:31 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 379HKV7j019969; Wed, 9 Aug 2023 17:20:31 GMT (envelope-from git) Date: Wed, 9 Aug 2023 17:20:31 GMT Message-Id: <202308091720.379HKV7j019969@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 13da84237a37 - main - e1000: Enable TSO on 82574 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 13da84237a37961938e9e237171ac111ddc1897c Auto-Submitted: auto-generated The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=13da84237a37961938e9e237171ac111ddc1897c commit 13da84237a37961938e9e237171ac111ddc1897c Author: Kevin Bowling AuthorDate: 2023-08-09 17:18:37 +0000 Commit: Kevin Bowling CommitDate: 2023-08-09 17:19:37 +0000 e1000: Enable TSO on 82574 Further testing indicates something wrong with particular reciever, enabling TSO 82574 for wider testing. Tested by: karels MFC after: 3 months --- sys/dev/e1000/if_em.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c index fefd1e3f411c..069ff37c6a75 100644 --- a/sys/dev/e1000/if_em.c +++ b/sys/dev/e1000/if_em.c @@ -906,9 +906,6 @@ em_if_attach_pre(if_ctx_t ctx) scctx->isc_tx_csum_flags = CSUM_TCP | CSUM_UDP | CSUM_IP_TSO | CSUM_IP6_TCP | CSUM_IP6_UDP; - /* Disable TSO on 82574L due to performance loss being investigated */ - if (hw->mac.type == e1000_82574) - scctx->isc_capenable &= ~IFCAP_TSO; /* * Disable TSO on SPT due to errata that downclocks DMA performance * i218-i219 Specification Update 1.5.4.5