Date: Tue, 18 Mar 2014 21:46:55 GMT From: Bertram Scharpf <software@bertram-scharpf.de> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/187711: All Mozilla extensions install symlinks into wrong places Message-ID: <201403182146.s2ILktUA046194@cgiserv.freebsd.org> Resent-Message-ID: <201403182150.s2ILo0vG091192@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 187711
>Category: ports
>Synopsis: All Mozilla extensions install symlinks into wrong places
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Mar 18 21:50:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Bertram Scharpf
>Release: 10.0
>Organization:
>Environment:
Not relevant
>Description:
I installed www/xpi-noscript and www/xpi-adblockplus from /usr/ports. Then I made packages and installed them on a second machine. Suddenly I had some weird directories /usr/ports/www/xpi-noscript/work/stage/usr/ports/www/xpi-noscript/work/stage/usr/local/lib/xpi and so forth. Firefox did not find the add-ons.
I wrote a fix and now my packages work.
This bug is a real shame! How can something like this happen?
>How-To-Repeat:
>Fix:
Author: Bertram Scharpf <software@bertram-scharpf.de>
Date: 2014-03-18 22:36:24 +0100
Bugfix Mozilla-Xpi
diff --git a/www/xpi-adblock/Makefile.xpi b/www/xpi-adblock/Makefile.xpi
index ddc591d..85e26cb 100644
--- a/www/xpi-adblock/Makefile.xpi
+++ b/www/xpi-adblock/Makefile.xpi
@@ -136,10 +136,10 @@ XPI_APPS+= ${LOCALBASE}/lib/${xpi}/extensions
XPI_SLDIRS_ALL= ${XPI_APPS_ALL:S.^.${XPI_SLDIR}/.}
XPI_SLDIRS= ${USE_XPI:S.^.${XPI_SLDIR}/.}
-XPI_LINKFARMS= ${XPI_APPS} ${XPI_SLDIRS}
+XPI_LINKFARMS= ${XPI_APPS} ${XPI_SLDIRS:S,^${STAGEDIR},,}
XPI_LIBDIR?= ${STAGEDIR}${PREFIX}/lib/xpi
-XPI_SLDIR?= ${STAGEDIR}${XPI_LIBDIR}/symlinks
+XPI_SLDIR?= ${XPI_LIBDIR}/symlinks
.ifndef XPI_DISTNAMES
XPI_XPIDIR?= ${XPI_LIBDIR}/${XPI_ID}
.endif
@@ -174,7 +174,7 @@ do-install:
@${CHMOD} -R a+rX,go-w ${_TD_FULL}/
@for _dir in ${XPI_LINKFARMS} ; { ${LN} -sf ${_TD_FULL} $$_dir/ ${_Q} ; }
@${ECHO_CMD} '@exec ${INSTALL} -d ${XPI_SLDIRS_ALL:S,^${STAGEDIR}${PREFIX},%D,}' ${_A}
- @${ECHO_CMD} '@exec for _dir in ${XPI_LINKFARMS} ; { ${LN} -sf ${_TD_FULL} $$_dir/ ${_Q}; }' ${_A}
+ @${ECHO_CMD} '@exec for _dir in ${XPI_LINKFARMS} ; { ${LN} -sf ${PREFIX}/${_TD} $$_dir/ ${_Q}; }' ${_A}
@${ECHO_CMD} '@unexec for _dir in ${XPI_LINKFARMS} ; { ${RM} -f $$_dir/${XPI_ID} ; }' ${_A}
@${ECHO_CMD} '@unexec rmdir ${XPI_DIRS_TRY:S,^,%D/,} ${_Q}' ${_A}
.endif
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201403182146.s2ILktUA046194>