From owner-freebsd-current Wed Oct 9 5:23:21 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8ADD337B401 for ; Wed, 9 Oct 2002 05:23:20 -0700 (PDT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4FED243E42 for ; Wed, 9 Oct 2002 05:23:20 -0700 (PDT) (envelope-from mux@freebsd.org) Received: by elvis.mu.org (Postfix, from userid 1920) id 0E5A9AE160; Wed, 9 Oct 2002 05:23:20 -0700 (PDT) Date: Wed, 9 Oct 2002 05:23:20 -0700 From: Maxime Henrion To: Bruce Evans Cc: "Vladimir B. Grebenschikov" , freebsd-current@FreeBSD.ORG Subject: Re: DDB sysctl function Message-ID: <20021009122319.GS57622@elvis.mu.org> References: <20021009094616.GP57622@elvis.mu.org> <20021009222321.I4967-100000@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021009222321.I4967-100000@gamplex.bde.org> User-Agent: Mutt/1.4i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Bruce Evans wrote: > On Wed, 9 Oct 2002, Maxime Henrion wrote: > > > What I meant in my previous mail is that you could malloc() these > > objects instead of putting them on the stack. Also, you don't need > > buffers that big since the size you need is bounded at max(sizeof(int), > > TOK_STRING_SIZE), which is likely to be TOK_STRING_SIZE :-). > > ddb can't call malloc() or any other general memory allocation function, > since it may be (and often is) invoked in the middle of such functions. I guess using a buffer of TOK_STRING_SIZE bytes for the tIDENT case and int for the tNUMBER case would be best then. We could use the same buffer if we don't plan to support platforms with ints bigger than 120 bytes :-). Maxime To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message