From owner-cvs-all@FreeBSD.ORG  Wed Mar 30 03:10:28 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id ABE0E16A4CF; Wed, 30 Mar 2005 03:10:28 +0000 (GMT)
Received: from leguin.anholt.net (69-30-77-85.dq1sn.easystreet.com
	[69.30.77.85])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id EE1CD43D1D; Wed, 30 Mar 2005 03:10:27 +0000 (GMT)
	(envelope-from anholt@FreeBSD.org)
Received: from leguin.anholt.net (localhost [127.0.0.1])
	by leguin.anholt.net (8.13.3/8.13.1) with ESMTP id j2U3ARjQ032995;
	Tue, 29 Mar 2005 19:10:27 -0800 (PST)
	(envelope-from anholt@FreeBSD.org)
Received: (from anholt@localhost)
	by leguin.anholt.net (8.13.3/8.13.1/Submit) id j2U3AQXX032994;
	Tue, 29 Mar 2005 19:10:26 -0800 (PST)
	(envelope-from anholt@FreeBSD.org)
X-Authentication-Warning: leguin.anholt.net: anholt set sender to
	anholt@FreeBSD.org using -f
From: Eric Anholt <anholt@FreeBSD.org>
To: obrien@FreeBSD.org
In-Reply-To: <20050329202834.GA35518@dragon.NUXI.org>
References: <200503292017.j2TKHlaa062618@repoman.freebsd.org>
	 <20050329202834.GA35518@dragon.NUXI.org>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Date: Tue, 29 Mar 2005 19:10:26 -0800
Message-Id: <1112152226.32986.2.camel@leguin>
Mime-Version: 1.0
X-Mailer: Evolution 2.2.0 FreeBSD GNOME Team Port 
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/memcontrol memcontrol.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: eta@lclark.edu
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Mar 2005 03:10:29 -0000

On Tue, 2005-03-29 at 12:28 -0800, David O'Brien wrote:
> On Tue, Mar 29, 2005 at 08:17:47PM +0000, Eric Anholt wrote:
> > anholt      2005-03-29 20:17:47 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     usr.sbin/memcontrol  memcontrol.c 
> >   Log:
> >   Correct formatting of pointers in the listing by using "0x%" PRIx64 instead of
> >   "%" PRIu64 "x".
> 
> I'd like to tweak this even more:
> 
> +	printf("%#.*" PRIx64 "/%" PRIu64 " %.8s ",
> +	    sizeof mrd[i].mr_base, mrd[i].mr_base, mrd[i].mr_len,
> +	    mrd[i].mr_owner[0] ? mrd[i].mr_owner : "-");
> 
> This gives output like:
> 
> 0x00010000/65536 BIOS write-back fixed-base fixed-length set-by-firmware active 
> 0x00080000/16384 BIOS write-back fixed-base fixed-length set-by-firmware active 
> 
> I think lengths in decimal are more clear, and having addresses lined up
> also makes it easier to read the output.

I like the 0 prepending on the offset, for sure.  I'm ambivalent about
length being decimal (really could go either way).