From owner-svn-src-head@freebsd.org Wed Jan 13 00:54:05 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 36A70A80991 for ; Wed, 13 Jan 2016 00:54:05 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 18957139A for ; Wed, 13 Jan 2016 00:54:04 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from ilsoft.org (unknown [73.34.117.227]) by outbound1.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Wed, 13 Jan 2016 00:54:40 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.14.9) with ESMTP id u0D0s3Hx006025; Tue, 12 Jan 2016 17:54:03 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1452646442.46848.37.camel@freebsd.org> Subject: Re: svn commit: r293724 - in head/sys/boot: arm64/libarm64 common efi/boot1 efi/fdt efi/include efi/include/arm64 efi/libefi efi/loader efi/loader/arch/amd64 efi/loader/arch/arm efi/loader/arch/arm64 i... From: Ian Lepore To: Steven Hartland , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Tue, 12 Jan 2016 17:54:02 -0700 In-Reply-To: <56959DA7.9050206@freebsd.org> References: <201601120217.u0C2HdBC089684@repo.freebsd.org> <1452645668.46848.34.camel@freebsd.org> <56959DA7.9050206@freebsd.org> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2016 00:54:05 -0000 On Wed, 2016-01-13 at 00:43 +0000, Steven Hartland wrote: > On 13/01/2016 00:41, Ian Lepore wrote: > > On Tue, 2016-01-12 at 02:17 +0000, Steven Hartland wrote: > > > Author: smh > > > Date: Tue Jan 12 02:17:39 2016 > > > New Revision: 293724 > > > URL: https://svnweb.freebsd.org/changeset/base/293724 > > > > > > Log: > > > Enable warnings in EFI boot code > > > > > > Set WARNS if not set for EFI boot code and fix the issues > > > highlighted by > > > setting it. > > > > > This appears to break arm builds when gcc is the compiler: > > > > cc1: warnings being treated as errors > > In file included from > > /local/build/staging/freebsd/rm92/src/sys/boot/efi/fdt/../include/e > > fi.h:52, > > from > > /local/build/staging/freebsd/rm92/src/sys/boot/efi/fdt/efi_fdt.c:35 > > : > > /local/build/staging/freebsd/rm92/src/sys/boot/efi/fdt/../include/e > > fiapi.h:535: warning: function declaration isn't a prototype > > In file included from > > /local/build/staging/freebsd/rm92/src/sys/boot/efi/fdt/efi_fdt.c:39 > > : > > /local/build/staging/freebsd/rm92/src/sys/boot/efi/fdt/../../common > > /bootstrap.h:332: warning: redundant redeclaration of 'delay' > > /local/build/staging/freebsd/rm92/src/sys/boot/efi/fdt/../include/e > > filib.h:53: warning: previous declaration of 'delay' was here > > /local/build/staging/freebsd/rm92/src/sys/boot/efi/fdt/../../common > > /bootstrap.h:336: warning: redundant redeclaration of 'time' > > /bsdstg/rm92/obj/arm.arm/local/build/staging/freebsd/rm92/src/tmp/u > > sr/include/time.h:154: warning: previous declaration of 'time' was > > here > > > > -- Ian > Passes a full tinderbox so I assume your forcing gcc for some reason? For several reasons. The fact that gcc isn't the default compiler doesn't mean that it's okay for code to not compile with gcc; it's still a supported compiler for arm. -- Ian