From owner-svn-src-head@FreeBSD.ORG Mon Mar 30 20:54:31 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6E90E6D1; Mon, 30 Mar 2015 20:54:31 +0000 (UTC) Received: from mail-ie0-x232.google.com (mail-ie0-x232.google.com [IPv6:2607:f8b0:4001:c03::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 32CA43E8; Mon, 30 Mar 2015 20:54:31 +0000 (UTC) Received: by iedfl3 with SMTP id fl3so486058ied.1; Mon, 30 Mar 2015 13:54:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=J7sEHlPp/mW5y1SvC4tsym3N0dpNzLxAAz08HdMgjZU=; b=hJOKEic8ZFTUPg9MAIVQ+Eakvs4EGFPy+7KX+wpQMFspSdHwhuDd3S2FX9sE+cng9k r4ipXg4q65XwFCrDPiNzHOtxhiCEimXyj4oRGh8fpXUuPDIqiL0SX120/BJm9qEkNZEr iXsYhWsZrWyRHE0OpThXKu4wEsLSwZkGMjB5KDxmh/YVNwM20lnlDSOzGJFNsvQ7Zy3R RWcMn6WUzLUtA1mG0iTy6g8DQCexjhvqUG2Z42tqUIIQDYtQWMqArBn7Psc715JF7oKy 2pocRjoXC2tnBsPKi2xVL5l1a+Sc5cIq6rVY+5o3o2/0XpZyoRcZbpbG6iO8H2KORpwn 41ug== MIME-Version: 1.0 X-Received: by 10.50.36.65 with SMTP id o1mr20428440igj.32.1427748870563; Mon, 30 Mar 2015 13:54:30 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.36.17.194 with HTTP; Mon, 30 Mar 2015 13:54:30 -0700 (PDT) In-Reply-To: <2308891.2rLa0R7ktj@ralph.baldwin.cx> References: <201503282341.t2SNfOZc032386@svn.freebsd.org> <3261888.gflh0beI2v@ralph.baldwin.cx> <2308891.2rLa0R7ktj@ralph.baldwin.cx> Date: Mon, 30 Mar 2015 13:54:30 -0700 X-Google-Sender-Auth: 3Wr97gklPgIzg60I2Tobya6MmDo Message-ID: Subject: Re: svn commit: r280799 - head/sys/dev/ath From: Adrian Chadd To: John Baldwin Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2015 20:54:31 -0000 On 30 March 2015 at 13:32, John Baldwin wrote: > On Monday, March 30, 2015 10:10:43 AM Adrian Chadd wrote: >> Yes, because it's before the dynamic hint stuff starts up. (kern.hintmode.) >> >> Hints don't show up in kenv on the mips boards until I set the sysctl >> to the "import them now!" setting. > > Everything in if_ath.c happens well after SYSINITs are going. Are you > explicitly forcing hintmode to 1 in your kernel config? At least on > x86 it always is zero and always pulls from kenv. > > If this is magic that config does when you have static hints, then why > not have init_dynamic_kenv() call into subr_hints.c to pull all the > static hints into the kenv right away? SI_SUB_KMEM is way, way before > any device drivers start doing anything. This is on MIPS and not on x86. And yes, I checked - both arge and ath probe/attach get called with no hints in kenv (ie, static hints) and I don't recall the hintmode being explicitly set in a config file. I'd love to make it work via hints calls; it'd significantly simplify things. -a