From owner-freebsd-emulation@FreeBSD.ORG Wed Mar 4 10:25:35 2009 Return-Path: Delivered-To: freebsd-emulation@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 476001065672 for ; Wed, 4 Mar 2009 10:25:35 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id D13048FC20 for ; Wed, 4 Mar 2009 10:25:34 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from outgoing.leidinger.net (pD9E2E957.dip.t-dialin.net [217.226.233.87]) by redbull.bpaserver.net (Postfix) with ESMTP id 0867C2E0CA; Wed, 4 Mar 2009 11:25:30 +0100 (CET) Received: from webmail.leidinger.net (webmail.leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 99AEE23A0; Wed, 4 Mar 2009 11:25:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=Leidinger.net; s=outgoing-alex; t=1236162326; bh=qNnoq3z+2oYdYby02UWFen1c1py0/r/c4 6gXwYAdFNg=; h=Message-ID:Date:From:To:Cc:Subject:References: In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=GuK69pHQAItlMsLPwwSh9BUaQHNjCtKZUc7+xLfbI07qKdiYs6fhYfAVDd0gPSopv zhcOkcrrjJkGcp63xITm316sS5KdYej2oh4CL4jm4QisvD9R1ru+wmjvHQt8LLeOsrk HIHzrNHX8OTJUpbo9EIxsPBkqu2vu4rBKifPZoAR663TgREaYmULPBYaAzUJ1NmQfdr QeE3brqsYfut8tisJYWsllEwHDxaB9NDKZALXvOIA1U8qKly2LZjPdlKGnsTDC6Cprr YK1hctOnFVyyzrItWewXsHFXK4841TTNDKulKK0aA2BN1zuYoWeq//wAQeRSPx/FlxU sVnSCEemA== Received: (from www@localhost) by webmail.leidinger.net (8.14.3/8.13.8/Submit) id n24APPQm024945; Wed, 4 Mar 2009 11:25:25 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Wed, 04 Mar 2009 11:25:24 +0100 Message-ID: <20090304112524.45016b7uvodhvvok@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Wed, 04 Mar 2009 11:25:24 +0100 From: Alexander Leidinger To: Boris Samorodov References: <14905754@bb.ipt.ru> <20090304093137.10733oaty524f0is@webmail.leidinger.net> <11370520@bb.ipt.ru> <20090304103247.417765zrsapwwow0@webmail.leidinger.net> <79218247@bb.ipt.ru> In-Reply-To: <79218247@bb.ipt.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.3) / FreeBSD-8.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-MailScanner-ID: 0867C2E0CA.C245F X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, ORDB-RBL, SpamAssassin (not cached, score=-13.427, required 6, BAYES_00 -15.00, DKIM_SIGNED 0.00, DKIM_VERIFIED -0.00, MIME_QP_LONG_LINE 1.40, RDNS_DYNAMIC 0.10, TW_FN 0.08) X-BPAnet-MailScanner-From: alexander@leidinger.net X-Spam-Status: No Cc: freebsd-emulation@freebsd.org Subject: Re: [patch] Mk/bsd.linux-rpm.mk: introduce some linux-f8 infrastructure X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2009 10:25:35 -0000 Quoting Boris Samorodov (from Wed, 04 Mar 2009 13:01:28 +0300)= : > Alexander Leidinger writes: >> Quoting Boris Samorodov (from Wed, 04 Mar 2009 =20 >> 12:23:35 +0300): >>> Alexander Leidinger writes: >>>> Quoting Boris Samorodov (from Tue, 03 Mar 2009 >> >>>>> . define MASTER_SITE_SUBDIR and MASTER_SITE_SRC_SUBDIR when >>>>> LINUX_DIST_VER=3D8 (no such ports ATM). >>>> >>>> Why is there ifndef MASTER_SITES (only in the context of your patch, >>> >>> This ifndef was introduced by sat@ at Rev 1.9. I'm not aware of the >>> real need. >> >> I had a look at it. It is about protecting MASTER_SITE_* to be set, >> e.g. imagine if someone sets MASTER_SITE=3Dfile:///..., and at this >> location there's a flat file structure. In this case you do not want >> to have MASTER_SITE_* to be set. >> >> So I think you need to change your patch to keep this functionality. > > Yes, good catch, thanks! The first .endif was misplaced. Seems that > the following patch is what you meant: Yes, looks commit ready. Personally I would remove the '?' from MASTER_SITE?=3D, as it is handled =20 by the ifndef. This way it does not confuse readers. MAybe even =20 putting a comment there what this is all about. Bye, Alexander. --=20 Grelb's Reminder: =09Eighty percent of all people consider =09themselves to be above average drivers. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137