From owner-freebsd-bugs@FreeBSD.ORG Sun Dec 11 13:50:03 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4EE29106568F for ; Sun, 11 Dec 2011 13:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 381808FC28 for ; Sun, 11 Dec 2011 13:50:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pBBDo3AT020187 for ; Sun, 11 Dec 2011 13:50:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pBBDo3sr020186; Sun, 11 Dec 2011 13:50:03 GMT (envelope-from gnats) Date: Sun, 11 Dec 2011 13:50:03 GMT Message-Id: <201112111350.pBBDo3sr020186@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: "Poul-Henning Kamp" Cc: Subject: Re: kern/163076: It is not possible to read in chunks from linprocfs and procfs. X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Poul-Henning Kamp List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Dec 2011 13:50:03 -0000 The following reply was made to PR kern/163076; it has been noted by GNATS. From: "Poul-Henning Kamp" To: Jaakko Heinonen Cc: Petr Salinger , bug-followup@FreeBSD.org, des@FreeBSD.org, mdf@FreeBSD.org Subject: Re: kern/163076: It is not possible to read in chunks from linprocfs and procfs. Date: Sun, 11 Dec 2011 13:41:03 +0000 In message <20111211102608.GA2266@a91-153-116-96.elisa-laajakaista.fi>, Jaakko Heinonen writes: >On 2011-12-10, Poul-Henning Kamp wrote: >One problem is the different malloc() semantics. The kernel version uses >M_WAITOK allocations while user space malloc(3) can fail. Yes, that's Dag-Erlings and my point: The semantics are too different. >Only 21 of 133 calls I grepped through the FreeBSD source tree did check >the return value [of sbuf_finish()] How many of them checked sbuf_error() instead ? And seriously: how long would it take to fix 112 calls ? -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.