Date: Sun, 11 Dec 2011 13:50:03 GMT From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/163076: It is not possible to read in chunks from linprocfs and procfs. Message-ID: <201112111350.pBBDo3sr020186@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/163076; it has been noted by GNATS. From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Jaakko Heinonen <jh@FreeBSD.org> Cc: Petr Salinger <Petr.Salinger@seznam.cz>, bug-followup@FreeBSD.org, des@FreeBSD.org, mdf@FreeBSD.org Subject: Re: kern/163076: It is not possible to read in chunks from linprocfs and procfs. Date: Sun, 11 Dec 2011 13:41:03 +0000 In message <20111211102608.GA2266@a91-153-116-96.elisa-laajakaista.fi>, Jaakko Heinonen writes: >On 2011-12-10, Poul-Henning Kamp wrote: >One problem is the different malloc() semantics. The kernel version uses >M_WAITOK allocations while user space malloc(3) can fail. Yes, that's Dag-Erlings and my point: The semantics are too different. >Only 21 of 133 calls I grepped through the FreeBSD source tree did check >the return value [of sbuf_finish()] How many of them checked sbuf_error() instead ? And seriously: how long would it take to fix 112 calls ? -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201112111350.pBBDo3sr020186>