From owner-cvs-all  Sun Jun  3 16:58:43 2001
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id B695537B401; Sun,  3 Jun 2001 16:58:38 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id JAA04530;
	Mon, 4 Jun 2001 09:58:22 +1000
Date: Mon, 4 Jun 2001 09:56:45 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-Sender: bde@besplex.bde.org
To: Jesper Skriver <jesper@skriver.dk>
Cc: Warner Losh <imp@village.org>,
	Michael Harnois <mdharnois@home.com>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern uipc_accf.c uipc_mbuf.c uipc_socket2.c
 src/sys/netinet ip_input.c src/sys/netinet6 in6_proto.c src/sys/sys param.h
In-Reply-To: <20010601102422.D23169@skriver.dk>
Message-ID: <Pine.BSF.4.21.0106040941090.53000-100000@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Fri, 1 Jun 2001, Jesper Skriver wrote:

> On Fri, Jun 01, 2001 at 10:14:25AM +0200, Jesper Skriver wrote:
> > On Thu, May 31, 2001 at 07:03:56PM -0600, Warner Losh wrote:
> > > In message <868zjdjatx.fsf@mharnois.workgroup.net> Michael Harnois writes:
> > > : cc -O -pipe -march=pentiumpro -Wall   -I/usr/obj/usr/src/i386/usr/include  -c /usr/src/games/fortune/strfile/strfile.c
> > > : In file included from /usr/src/games/fortune/strfile/strfile.c:54:
> > > : /usr/include/sys/param.h:236: opt_param.h: No such file or directory
> > > 
> > > Ah, the classic "I included opt_foo.h from a file that was exported to
> > > userland" problem.
> > 
> > Bummer, I don't have time to fix it right now (probably put it in
> > a new .h file), so I'll back it out for now, and have a second go
> > when I have more time.
> 
> http://people.FreeBSD.org/~jesper/opt_param.diff
> 
> Should fix this, it moved NMBCLUSTERS back to
> src/sys/kern/uipc_mbuf.c, revert <sys/param.h> to the old version,
> and sets the default value for net.inet.ip.maxfragpackets and
> net.inet6.ip6.maxfragpackets to 200 instead of NMBCLUSTERS/4

I think you want it to be (nmbclusters / 4), not NMBCLUSTERS/4.  The
variables in param.c are supposed to actually be variables (it is
always possible to change them by patching the binary, even if they
are not boot-time tunables).  Using the compile-time constants for
secondary variables just gives wrong values if the primary variables
are changed, or more variables to patch/tune manually.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message