Date: Fri, 7 Mar 2014 09:43:36 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: d@delphij.net Cc: Mathieu Arnold <mat@FreeBSD.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Xin LI <delphij@FreeBSD.org>, ports-committers@freebsd.org Subject: Re: svn commit: r345165 - head/devel/hgsvn Message-ID: <20140307094336.GB3390@FreeBSD.org> In-Reply-To: <53198F86.3020800@delphij.net> References: <201402192351.s1JNplot033193@svn.freebsd.org> <20140307070536.GB48720@FreeBSD.org> <CE672AB00747E2D97403FA66@atuin.in.mat.cc> <53198F86.3020800@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 07, 2014 at 01:21:10AM -0800, Xin Li wrote: > > If you want to complain about something, complain about the removal > > of DIST_SUBDIR, not what was already discussed two weeks ago. > > I wouldn't mind adding that back but what's the best practice? Do we > put all python ports in python unless they already have their own > directory (e.g. zope)? DIST_SUBDIR is most useful in few cases (not mutually-exclusive): 1) to isolate group (perhaps large group) from other distfiles; 2) when distfiles related to a port do not look related on their own; 3) when two identically named distfiles (libfoobar-42.tar.gz) belong to different ports, and are with different contents (if contents is the same, DIST_SUBDIR should not be used, or be the same to reduce file duplication in $DISTDIR); 4) maybe something else. In case of DIST_SUBDIR=python, I'm not sure: on my build box here, it contains about 10 files (Python itself, Sphinx, setuptools). In $DISTDIR itself, there are some files that start with py2?-?.*. Thus, I'm not sure if there is a reason to complain about removal of DIST_SUBDIR; but perhaps python@ gang would disagree. > Also speaking for that USE_ZIP change, should I restore it to previous > state (use EXTRACT_SUFX)? Technically, yes (if InfoZip is indeed non needed); however, you might want to do it later alongside with other changes (as USE_ZIP issue is minuscule). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140307094336.GB3390>