From owner-svn-src-head@FreeBSD.ORG Wed Apr 8 16:26:30 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E605790; Wed, 8 Apr 2015 16:26:30 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BDD8018A; Wed, 8 Apr 2015 16:26:30 +0000 (UTC) Received: from ralph.baldwin.cx (pool-173-54-116-245.nwrknj.fios.verizon.net [173.54.116.245]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 83F46B924; Wed, 8 Apr 2015 12:26:29 -0400 (EDT) From: John Baldwin To: Gleb Smirnoff Subject: Re: svn commit: r281188 - head/usr.bin/netstat Date: Wed, 08 Apr 2015 12:24:48 -0400 Message-ID: <6969546.Tk7XnsGrVd@ralph.baldwin.cx> User-Agent: KMail/4.14.2 (FreeBSD/10.1-STABLE; KDE/4.14.2; amd64; ; ) In-Reply-To: <201504070550.t375oklh014315@svn.freebsd.org> References: <201504070550.t375oklh014315@svn.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Wed, 08 Apr 2015 12:26:29 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Apr 2015 16:26:31 -0000 On Tuesday, April 07, 2015 05:50:46 AM Gleb Smirnoff wrote: > Author: glebius > Date: Tue Apr 7 05:50:45 2015 > New Revision: 281188 > URL: https://svnweb.freebsd.org/changeset/base/281188 > > Log: > Like it was already done for 'netstat -i', drop the kvm(3) support > in 'netstat -r'. > > The netstat/route.c was the last abuser of struct ifnet and struct > rtentry in the tree. With this change if_var.h can become kernel > only include, _WANT_RTENTRY can go away and projects/ifnet and > projects/routing can go forward. > > Differential Revision: https://reviews.freebsd.org/D2242 > Reviewed by: melifaro, gnn > Sponsored by: Nginx, Inc. > Sponsored by: Netflix This breaks netstat -r on a crashdump. Just because you don't find this information useful during post-mortem debugging doesn't mean that other folks do not. The easiest solution is to update crashinfo to remove the netstat commands it runs. However, I don't understand the fear that system binaries can peek inside the kernel for debugging info. It's ok for it to be a fragile ABI that isn't exposed to normal applications and to require people to keep a matching netstat with their kernel (along with the other tools crashinfo calls). Just update the code in netstat to cope with the new data structures. That should be much easier to test than having to convert N device drivers. -- John Baldwin