From owner-freebsd-testing@FreeBSD.ORG Wed Apr 30 17:28:04 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DA059754; Wed, 30 Apr 2014 17:28:04 +0000 (UTC) Received: from mail-ve0-x230.google.com (mail-ve0-x230.google.com [IPv6:2607:f8b0:400c:c01::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 72FC71C4D; Wed, 30 Apr 2014 17:28:04 +0000 (UTC) Received: by mail-ve0-f176.google.com with SMTP id db11so2556160veb.35 for ; Wed, 30 Apr 2014 10:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=MMuT+uazAjJMSRm1JfD8KQXHo7ButS/cGY8uzOVtOQw=; b=XMOfomqyDTZE4XENZEbiQdQnYo42TTC6SqohMl//p8Nmpu5ZbrMKWZuMa+dRJU1qK6 AAnYSj9Gg1/b6TR/AfEawxesvo/dY32NzHZf8HPvmoqXemzb7MSEfHSw5ZZ2tGJpK7B0 ZD/rr/H52daOceBNwFZyivPdBq/hgxtE9HEhZfehv7Kwa04Y92kME3M4YvI6MsMtEyn/ C/ttPO3ffOaoT3YKXQLRU+C0BpJRuiO1PJjgXA++TvUrQN3KLfuRL/wMpPDqilGdSLTd 6rQ17Z0v5V+bRGA70sU/Gd+7XyYj4caUHZgHxIBvekooO045TNfFboZCnlTeH57t+SmG R8eA== MIME-Version: 1.0 X-Received: by 10.221.59.194 with SMTP id wp2mr749149vcb.59.1398878883585; Wed, 30 Apr 2014 10:28:03 -0700 (PDT) Received: by 10.221.67.136 with HTTP; Wed, 30 Apr 2014 10:28:03 -0700 (PDT) In-Reply-To: <16437CC5729B5345AF77F816513376E820BCBE25@MX103CL02.corp.emc.com> References: <16437CC5729B5345AF77F816513376E820BAF854@MX103CL02.corp.emc.com> <5F1D5D49-5F39-4EAC-89D5-E4D10FB3B01E@freebsd.org> <16437CC5729B5345AF77F816513376E820BAFE8E@MX103CL02.corp.emc.com> <16437CC5729B5345AF77F816513376E820BCBE25@MX103CL02.corp.emc.com> Date: Wed, 30 Apr 2014 10:28:03 -0700 Message-ID: Subject: Re: Please provide process for small, targeted fixes in tools/regression From: Garrett Cooper To: "Peel, Casey" Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-testing@freebsd.org" , "bdrewery@FreeBSD.org" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Apr 2014 17:28:04 -0000 On Wed, Apr 30, 2014 at 10:03 AM, Peel, Casey wrote: > Julio, here are 3 additional changes in tools/regression to get tests in there to run and pass via prove. > > * libutil.diff - fixes test-humanize_number.c to print 1-based test numbers instead of 0-based test numbers as prove expects. > * mmap.diff - adds .t file to allow running mmap test through prove > * fifo.diff - adds a top-level Makefile to compile the code in the fifo/ subdirectories. Adds .t to run the tests via prove. These changes look ok. The only thing (just a consistency nit) is that I would choose a consistent way of incrementing in loops, i.e. i=$(expr $i + 1) : $(( i += 1 )) i=$(( $i + 1 )) e.g. $ cat increment.sh ; sh increment.sh #!/bin/sh set -x sh -c 'i=$(expr $i + 1); echo $i' sh -c ': $(( i += 1 )); echo $i' sh -c 'i=$(( $i + 1 )); echo $i' + sh -c 'i=$(expr $i + 1); echo $i' 1 + sh -c ': $(( i += 1 )); echo $i' 1 + sh -c 'i=$(( $i + 1 )); echo $i' 1 On the other hand, if it's all going to be converted over to ATF in the near future, it doesn't really matter :). If you (or Peter) commit the work to isilon-atf, then I'll do the work required to convert it (minus the libutil testcases -- these need to be merged into what's in isilon-atf from NetBSD). Thanks! -Garrett